Issue 29756646: Noissue - Adapt best practices for trailing commas (abpssembly)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29756646: Noissue - Adapt best practices for trailing commas (abpssembly) (Closed)

Created:
April 19, 2018, 12:49 p.m. by Sebastian Noack

Modified:
April 20, 2018, 11:21 a.m.

Reviewers:
tlucas

CC:
Vasily Kuznetsov

Visibility:
Public.

Description

Noissue - Adapt best practices for trailing commas (abpssembly)

Patch Set 1 #

Patch Set 2 : Re-run script on Python 2, added flake8-commas extension #

Created: April 19, 2018, 2:41 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -144 lines)			Patch
M	sitescripts/content_blocker_lists/bin/generate_lists.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/extensions/bin/createNightlies.py	View		17 chunks	+19 lines, -19 lines	0 comments	Download
M	sitescripts/extensions/bin/legacy/packagerSafari.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sitescripts/extensions/bin/updateRecommendations.py	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	sitescripts/extensions/bin/updateUpdateManifests.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	sitescripts/extensions/utils.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	sitescripts/extensions/web/adblockbrowserUpdates.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sitescripts/formmail/test/test_formmail.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/formmail/web/formmail2.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/hg/bin/update_issues.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sitescripts/hg/test/update_issues.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	sitescripts/management/bin/generateHgAuth.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sitescripts/management/bin/generateNotifications.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/management/bin/installChanges.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/notifications/test/notification.py	View		20 chunks	+54 lines, -54 lines	0 comments	Download
M	sitescripts/notifications/web/notification.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/reports/bin/updateDigests.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/send_installation_link/web/send_installation_link.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sitescripts/stats/bin/logprocessor.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/stats/bin/pagegenerator.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sitescripts/stats/test/common.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sitescripts/stats/test/logprocessor.py	View	1	17 chunks	+24 lines, -24 lines	0 comments	Download
M	sitescripts/submit_email/web/submit_email.py	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	sitescripts/templateFilters.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sitescripts/testpages/web/sitekey_frame.py	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tox.ini	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Sebastian Noack

see https://codereview.adblockplus.org/29756624/

April 19, 2018, 12:52 p.m. (2018-04-19 12:52:27 UTC) #1

Sebastian Noack

After re-running my script with Python 2, flake8-commas found some more missing commas. Also I ...

April 19, 2018, 2:41 p.m. (2018-04-19 14:41:40 UTC) #2

tlucas

April 20, 2018, 7:14 a.m. (2018-04-20 07:14:40 UTC) #3

On 2018/04/19 14:41:40, Sebastian Noack wrote:
> After re-running my script with Python 2, flake8-commas found some more
missing
> commas. Also I added the flake8-commas extension to the tox.ini.

LGTM

Expand All Messages | Collapse All Messages