chainedconfigparser.py - Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chainedconfigparser.py

Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools) (Closed)

Patch Set: Re-run script on Python 2, added flake8-commas extension Created April 19, 2018, 2:09 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chainedconfigparser.py

===================================================================

--- a/chainedconfigparser.py

+++ b/chainedconfigparser.py

@@ -144,7 +144,7 @@

for option, value in ConfigParser.SafeConfigParser.items(self, section, *args, **kwargs):

items.append(Item(

option, value,

- self._origin[(section, self.optionxform(option))]

+ self._origin[(section, self.optionxform(option))],

))

return items

« no previous file with comments | « build.py ('k') | ensure_dependencies.py » ('j') | tox.ini » ('J')