Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29756688: Issue 6567 - Update buildtools to 47429f8d9b6a (Closed)

Created:
April 19, 2018, 1:08 p.m. by tlucas
Modified:
April 20, 2018, 12:09 p.m.
Reviewers:
Sebastian Noack, kzar
Visibility:
Public.

Description

Issue 6567 - Update buildtools to 47429f8d9b6a

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : NOCHANGE rebase against `next` (0dd150989c28) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -19 lines) Patch
M dependencies View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M metadata.chrome View 1 2 3 chunks +39 lines, -17 lines 0 comments Download

Messages

Total messages: 4
tlucas
Patch Set 1 Updated the buildtools dependency, adhered to integration (changing the contents of metadata.*) ...
April 19, 2018, 1:10 p.m. (2018-04-19 13:10:36 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29756688/diff/29756689/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29756688/diff/29756689/metadata.chrome#newcode46 metadata.chrome:46: Nit: Two blank lines between sections is inconsistent with ...
April 19, 2018, 1:19 p.m. (2018-04-19 13:19:55 UTC) #2
tlucas
Patch Set 2 * Addressed nits https://codereview.adblockplus.org/29756688/diff/29756689/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29756688/diff/29756689/metadata.chrome#newcode46 metadata.chrome:46: On 2018/04/19 13:19:54, ...
April 19, 2018, 1:26 p.m. (2018-04-19 13:26:18 UTC) #3
Sebastian Noack
April 19, 2018, 1:28 p.m. (2018-04-19 13:28:21 UTC) #4
LGTM. This goes into the "next" branch!

Powered by Google App Engine
This is Rietveld