Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: build-v8.gypi

Issue 29757568: Noissue - use -fPIC for android, required by libadbblockplus-android and descendants (Closed) Base URL: https://github.com/adblockplus/libadblockplus@30d67cf0eded534232005f045cc41d5c717715ff
Patch Set: Created April 20, 2018, 9:49 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'includes': ['common.gypi'], 2 'includes': ['common.gypi'],
3 'variables': { 3 'variables': {
4 'v8_enable_i18n_support': 0, 4 'v8_enable_i18n_support': 0,
5 'v8_optimized_debug': 0, 5 'v8_optimized_debug': 0,
6 'v8_use_external_startup_data': 0, 6 'v8_use_external_startup_data': 0,
7 'v8_use_snapshot': 1, 7 'v8_use_snapshot': 1,
8 'v8_random_seed%': 0, 8 'v8_random_seed%': 0,
9 'v8_android_log_stdout': 1, 9 'v8_android_log_stdout': 1,
10 }, 10 },
11 11
12 'target_defaults': { 12 'target_defaults': {
13 'defines': [ 13 'defines': [
14 '__ANDROID_API__=16', 14 '__ANDROID_API__=16',
15 ], 15 ],
16 }, 16 },
17 'conditions': [ 17 'conditions': [
18 ['OS=="linux" or OS=="mac"', { 18 ['OS=="linux" or OS=="mac" or OS=="android"', {
19 'target_defaults': { 19 'target_defaults': {
20 'cflags': [ '-fPIC' ], 20 'cflags': [ '-fPIC' ],
21 'cflags_cc': [ '-fPIC' ] 21 'cflags_cc': [ '-fPIC' ]
22 } 22 }
23 }], 23 }],
24 ['OS=="win"', { 24 ['OS=="win"', {
25 'target_defaults': { 25 'target_defaults': {
26 'configurations': { 26 'configurations': {
27 'Debug': { 27 'Debug': {
28 'conditions': [ 28 'conditions': [
(...skipping 11 matching lines...) Expand all
40 }, 40 },
41 'msvs_settings': { 41 'msvs_settings': {
42 'VCCLCompilerTool': { 42 'VCCLCompilerTool': {
43 'WarningLevel': 0, 43 'WarningLevel': 0,
44 }, 44 },
45 }, 45 },
46 } 46 }
47 }] 47 }]
48 ], 48 ],
49 } 49 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld