Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29757568: Noissue - use -fPIC for android, required by libadbblockplus-android and descendants (Closed)

Created:
April 20, 2018, 9:49 a.m. by sergei
Modified:
April 20, 2018, 9:55 a.m.
Reviewers:
anton, hub
Base URL:
https://github.com/adblockplus/libadblockplus@30d67cf0eded534232005f045cc41d5c717715ff
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build-v8.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
sergei
April 20, 2018, 9:50 a.m. (2018-04-20 09:50:05 UTC) #1
anton
April 20, 2018, 9:53 a.m. (2018-04-20 09:53:42 UTC) #2
On 2018/04/20 09:50:05, sergei wrote:

LGTM

Powered by Google App Engine
This is Rietveld