Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29757595: Noissue - Use plural for element hiding domains (Closed)

Created:
April 20, 2018, 8:22 p.m. by Manish Jethani
Modified:
May 4, 2018, 1:33 p.m.
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Use plural for element hiding domains

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M lib/filterClasses.js View 1 3 chunks +14 lines, -14 lines 0 comments Download
M test/filterClasses.js View 4 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 6
Manish Jethani
April 20, 2018, 8:22 p.m. (2018-04-20 20:22:37 UTC) #1
Manish Jethani
Patch Set 1 It's a bit confusing with the comma-separated list of domains is referred ...
April 20, 2018, 8:24 p.m. (2018-04-20 20:24:35 UTC) #2
Manish Jethani
Patch Set 2: Rebase Sorry, that was not on master. Now rebased.
April 20, 2018, 8:28 p.m. (2018-04-20 20:28:07 UTC) #3
kzar
I guess this can be closed now since we removed the getSelectors function.
May 2, 2018, 12:29 p.m. (2018-05-02 12:29:33 UTC) #4
Manish Jethani
Patch Set 3: Rebase On 2018/05/02 12:29:33, kzar wrote: > I guess this can be ...
May 2, 2018, 1:36 p.m. (2018-05-02 13:36:00 UTC) #5
kzar
May 3, 2018, 4:20 p.m. (2018-05-03 16:20:36 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld