Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(620)

Issue 29760704: Issue 6592 - Implement $rewrite filter option (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by hub
Modified:
4 months ago
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6592 - Implement $rewrite filter option

Patch Set 1 #

Patch Set 2 : Added test. The rewrite is now part of BlockingFilter #

Total comments: 11

Patch Set 3 : Use the replace syntax directly #

Total comments: 5

Patch Set 4 : Check origin on rewrite. #

Total comments: 10

Patch Set 5 : More review changes #

Total comments: 2

Patch Set 6 : Update doc comment. #

Total comments: 21

Patch Set 7 : Some comment adjustments. #

Patch Set 8 : Relative URL rewrite. #

Total comments: 6

Patch Set 9 : Comment fixes. #

Total comments: 21

Patch Set 10 : Some minor adjustments (comments, formatting) #

Patch Set 11 : Properly polyfill URL for NodeJS #

Total comments: 5

Patch Set 12 : Use typeof to check for undefined #

Patch Set 13 : Just inject URL into the sandbox globals. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -9 lines) Patch
M lib/filterClasses.js View 1 2 3 4 5 6 7 8 9 4 chunks +37 lines, -3 lines 2 comments Download
M test/.eslintrc.json View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M test/_common.js View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -6 lines 0 comments Download
M test/filterClasses.js View 1 2 3 4 5 6 7 8 9 4 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 62
hub
4 months, 3 weeks ago (2018-04-24 20:31:29 UTC) #1
hub
I need to add some tests.
4 months, 3 weeks ago (2018-04-24 20:32:08 UTC) #2
hub
https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js#newcode948 lib/filterClasses.js:948: return this.rewrite.replace("$1", matches[0]); This is simplistic though. It does ...
4 months, 3 weeks ago (2018-04-27 00:48:22 UTC) #3
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js#newcode948 lib/filterClasses.js:948: return this.rewrite.replace("$1", matches[0]); On 2018/04/27 00:48:22, hub wrote: > ...
4 months, 3 weeks ago (2018-04-30 20:07:11 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js#newcode851 lib/filterClasses.js:851: RegExpFilter.typeMap = { We should add REWRITE here. Then ...
4 months, 3 weeks ago (2018-04-30 20:10:55 UTC) #5
hub
Updated patch. https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js#newcode851 lib/filterClasses.js:851: RegExpFilter.typeMap = { On 2018/04/30 20:10:55, Manish ...
4 months, 3 weeks ago (2018-05-01 18:32:16 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29767580/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29767580/lib/filterClasses.js#newcode946 lib/filterClasses.js:946: let matches = this.regexp.exec(urlString); Why do we need to ...
4 months, 2 weeks ago (2018-05-02 15:10:06 UTC) #7
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js#newcode851 lib/filterClasses.js:851: RegExpFilter.typeMap = { On 2018/05/01 18:32:15, hub wrote: > ...
4 months, 2 weeks ago (2018-05-02 15:31:10 UTC) #8
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js#newcode944 lib/filterClasses.js:944: doRewrite(urlString) For what it's worth I would rather call ...
4 months, 2 weeks ago (2018-05-02 17:52:23 UTC) #9
hub
Updated patch https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29760750/lib/filterClasses.js#newcode851 lib/filterClasses.js:851: RegExpFilter.typeMap = { On 2018/05/02 15:31:09, Manish ...
4 months, 2 weeks ago (2018-05-02 22:14:33 UTC) #10
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js#newcode947 lib/filterClasses.js:947: if (rewritten != urlString) Why do we need that ...
4 months, 2 weeks ago (2018-05-02 22:25:03 UTC) #11
hub
https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js#newcode947 lib/filterClasses.js:947: if (rewritten != urlString) On 2018/05/02 22:25:03, Sebastian Noack ...
4 months, 2 weeks ago (2018-05-03 00:57:58 UTC) #12
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js#newcode947 lib/filterClasses.js:947: if (rewritten != urlString) On 2018/05/03 00:57:58, hub wrote: ...
4 months, 2 weeks ago (2018-05-03 01:14:52 UTC) #13
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js#newcode822 lib/filterClasses.js:822: else if (option == "REWRITE" && value) Note that ...
4 months, 2 weeks ago (2018-05-03 02:42:37 UTC) #14
hub
patch updated https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js#newcode822 lib/filterClasses.js:822: else if (option == "REWRITE" && value) ...
4 months, 2 weeks ago (2018-05-03 18:40:05 UTC) #15
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29769594/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29769594/lib/filterClasses.js#newcode942 lib/filterClasses.js:942: * @returns {string?} the rewritten URL, or null if ...
4 months, 2 weeks ago (2018-05-04 09:56:40 UTC) #16
hub
Updated pacth https://codereview.adblockplus.org/29760704/diff/29769594/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29769594/lib/filterClasses.js#newcode942 lib/filterClasses.js:942: * @returns {string?} the rewritten URL, or ...
4 months, 2 weeks ago (2018-05-04 16:18:48 UTC) #17
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js#newcode822 lib/filterClasses.js:822: else if (option == "REWRITE" && value) On 2018/05/03 ...
4 months, 2 weeks ago (2018-05-04 22:50:49 UTC) #18
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode949 lib/filterClasses.js:949: if (new URL(rewritten).origin == new URL(urlString).origin) On 2018/05/04 22:50:48, ...
4 months, 2 weeks ago (2018-05-04 23:41:46 UTC) #19
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode946 lib/filterClasses.js:946: let rewritten = urlString.replace(this.regexp, this.rewrite); On 2018/05/04 22:50:48, Manish ...
4 months, 2 weeks ago (2018-05-05 00:51:39 UTC) #20
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode949 lib/filterClasses.js:949: if (new URL(rewritten).origin == new URL(urlString).origin) On 2018/05/04 23:41:46, ...
4 months, 2 weeks ago (2018-05-05 13:34:43 UTC) #21
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode946 lib/filterClasses.js:946: let rewritten = urlString.replace(this.regexp, this.rewrite); How about this? let ...
4 months, 2 weeks ago (2018-05-05 17:07:07 UTC) #22
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode946 lib/filterClasses.js:946: let rewritten = urlString.replace(this.regexp, this.rewrite); On 2018/05/05 17:07:07, Sebastian ...
4 months, 2 weeks ago (2018-05-05 23:58:39 UTC) #23
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode946 lib/filterClasses.js:946: let rewritten = urlString.replace(this.regexp, this.rewrite); On 2018/05/05 23:58:39, Manish ...
4 months, 2 weeks ago (2018-05-06 00:45:41 UTC) #24
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode946 lib/filterClasses.js:946: let rewritten = urlString.replace(this.regexp, this.rewrite); On 2018/05/06 00:45:41, Manish ...
4 months, 2 weeks ago (2018-05-06 13:04:26 UTC) #25
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode946 lib/filterClasses.js:946: let rewritten = urlString.replace(this.regexp, this.rewrite); On 2018/05/06 00:45:41, Manish ...
4 months, 2 weeks ago (2018-05-06 13:59:31 UTC) #26
hub
Updated patch. https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29768685/lib/filterClasses.js#newcode822 lib/filterClasses.js:822: else if (option == "REWRITE" && value) ...
4 months, 2 weeks ago (2018-05-07 20:11:56 UTC) #27
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode946 lib/filterClasses.js:946: let rewritten = urlString.replace(this.regexp, this.rewrite); On 2018/05/06 13:04:25, Sebastian ...
4 months, 2 weeks ago (2018-05-08 06:57:30 UTC) #28
hub
Updated patch. https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29770573/lib/filterClasses.js#newcode946 lib/filterClasses.js:946: let rewritten = urlString.replace(this.regexp, this.rewrite); On 2018/05/08 ...
4 months, 2 weeks ago (2018-05-08 15:54:30 UTC) #29
Sebastian Noack
Other than that the change looks good to me. (I moved myself back to CC, ...
4 months, 2 weeks ago (2018-05-08 17:09:30 UTC) #30
hub
https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js#newcode941 lib/filterClasses.js:941: * @param {string} url the URL to rewrite On ...
4 months, 2 weeks ago (2018-05-08 17:14:49 UTC) #31
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js#newcode941 lib/filterClasses.js:941: * @param {string} url the URL to rewrite On ...
4 months, 2 weeks ago (2018-05-08 17:25:38 UTC) #32
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js#newcode941 lib/filterClasses.js:941: * @param {string} url the URL to rewrite On ...
4 months, 2 weeks ago (2018-05-08 18:52:32 UTC) #33
Manish Jethani
Adding dave@ instead of kzar@
4 months, 2 weeks ago (2018-05-08 18:53:45 UTC) #34
Manish Jethani
On 2018/05/08 18:52:32, Manish Jethani wrote: > LGTM By the way, I would write the ...
4 months, 1 week ago (2018-05-08 18:59:02 UTC) #35
hub
On 2018/05/08 18:59:02, Manish Jethani wrote: > On 2018/05/08 18:52:32, Manish Jethani wrote: > > ...
4 months, 1 week ago (2018-05-08 19:13:55 UTC) #36
Manish Jethani
On 2018/05/08 19:13:55, hub wrote: > On 2018/05/08 18:59:02, Manish Jethani wrote: > > On ...
4 months, 1 week ago (2018-05-09 13:42:31 UTC) #37
hub
On 2018/05/09 13:42:31, Manish Jethani wrote: > On 2018/05/08 19:13:55, hub wrote: > > On ...
4 months, 1 week ago (2018-05-09 14:24:48 UTC) #38
Manish Jethani
On 2018/05/09 14:24:48, hub wrote: > On 2018/05/09 13:42:31, Manish Jethani wrote: > > On ...
4 months, 1 week ago (2018-05-09 16:06:12 UTC) #39
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js#newcode935 lib/filterClasses.js:935: * @type {string} This should be {?string} now after ...
4 months, 1 week ago (2018-05-11 13:59:30 UTC) #40
hub
patch updated. https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29774568/lib/filterClasses.js#newcode935 lib/filterClasses.js:935: * @type {string} On 2018/05/11 13:59:29, Manish ...
4 months, 1 week ago (2018-05-11 15:57:33 UTC) #41
kzar
https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js#newcode900 lib/filterClasses.js:900: * The rewrite expression Mind making this comment useful? ...
4 months, 1 week ago (2018-05-15 14:08:59 UTC) #42
kzar
https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js#newcode955 lib/filterClasses.js:955: return url; Why do we return `url` on failure? ...
4 months, 1 week ago (2018-05-15 14:24:58 UTC) #43
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js#newcode955 lib/filterClasses.js:955: return url; On 2018/05/15 14:24:57, kzar wrote: > Why ...
4 months, 1 week ago (2018-05-15 14:40:34 UTC) #44
kzar
https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js#newcode955 lib/filterClasses.js:955: return url; On 2018/05/15 14:40:34, Sebastian Noack wrote: > ...
4 months, 1 week ago (2018-05-15 14:44:25 UTC) #45
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js#newcode955 lib/filterClasses.js:955: return url; On 2018/05/15 14:44:23, kzar wrote: > On ...
4 months, 1 week ago (2018-05-15 14:51:02 UTC) #46
kzar
https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js#newcode955 lib/filterClasses.js:955: return url; On 2018/05/15 14:51:02, Sebastian Noack wrote: > ...
4 months, 1 week ago (2018-05-15 14:53:58 UTC) #47
Manish Jethani
https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js#newcode955 lib/filterClasses.js:955: return url; On 2018/05/15 14:53:58, kzar wrote: > On ...
4 months, 1 week ago (2018-05-15 15:18:13 UTC) #48
hub
Updated patch. https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js#newcode900 lib/filterClasses.js:900: * The rewrite expression On 2018/05/15 14:08:58, ...
4 months, 1 week ago (2018-05-15 16:16:32 UTC) #49
hub
https://codereview.adblockplus.org/29760704/diff/29778589/test/_common.js File test/_common.js (left): https://codereview.adblockplus.org/29760704/diff/29778589/test/_common.js#oldcode34 test/_common.js:34: function URL(urlString) On 2018/05/15 16:16:31, hub wrote: > On ...
4 months, 1 week ago (2018-05-15 16:17:54 UTC) #50
kzar
https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29778589/lib/filterClasses.js#newcode900 lib/filterClasses.js:900: * The rewrite expression On 2018/05/15 16:16:31, hub wrote: ...
4 months ago (2018-05-16 09:22:40 UTC) #51
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29778589/test/_common.js File test/_common.js (left): https://codereview.adblockplus.org/29760704/diff/29778589/test/_common.js#oldcode34 test/_common.js:34: function URL(urlString) On 2018/05/16 09:22:40, kzar wrote: > On ...
4 months ago (2018-05-16 10:53:30 UTC) #52
hub
https://codereview.adblockplus.org/29760704/diff/29778589/test/_common.js File test/_common.js (left): https://codereview.adblockplus.org/29760704/diff/29778589/test/_common.js#oldcode34 test/_common.js:34: function URL(urlString) On 2018/05/16 10:53:29, Sebastian Noack wrote: > ...
4 months ago (2018-05-16 12:08:11 UTC) #53
Sebastian Noack
https://codereview.adblockplus.org/29760704/diff/29778589/test/_common.js File test/_common.js (left): https://codereview.adblockplus.org/29760704/diff/29778589/test/_common.js#oldcode34 test/_common.js:34: function URL(urlString) On 2018/05/16 12:08:11, hub wrote: > On ...
4 months ago (2018-05-16 12:13:23 UTC) #54
kzar
On 2018/05/16 12:13:23, Sebastian Noack wrote: > And it seems that this should even work ...
4 months ago (2018-05-16 12:35:05 UTC) #55
hub
Updated polyfill for URL, tested with NodeJS 7.10.1, NodeJS 8.5 and 8.11.2 and NodeJS 10.1 ...
4 months ago (2018-05-16 13:11:49 UTC) #56
kzar
https://codereview.adblockplus.org/29760704/diff/29783599/test/_common.js File test/_common.js (right): https://codereview.adblockplus.org/29760704/diff/29783599/test/_common.js#newcode34 test/_common.js:34: // URL is global in Node 10. In Node ...
4 months ago (2018-05-16 13:24:32 UTC) #57
hub
updated patch https://codereview.adblockplus.org/29760704/diff/29783599/test/_common.js File test/_common.js (right): https://codereview.adblockplus.org/29760704/diff/29783599/test/_common.js#newcode35 test/_common.js:35: if (global.URL == undefined) On 2018/05/16 13:24:31, ...
4 months ago (2018-05-16 18:33:24 UTC) #58
kzar
https://codereview.adblockplus.org/29760704/diff/29783599/test/_common.js File test/_common.js (right): https://codereview.adblockplus.org/29760704/diff/29783599/test/_common.js#newcode35 test/_common.js:35: if (global.URL == undefined) On 2018/05/16 18:33:23, hub wrote: ...
4 months ago (2018-05-17 09:49:02 UTC) #59
hub
updated patch https://codereview.adblockplus.org/29760704/diff/29783599/test/_common.js File test/_common.js (right): https://codereview.adblockplus.org/29760704/diff/29783599/test/_common.js#newcode35 test/_common.js:35: if (global.URL == undefined) On 2018/05/17 09:49:01, ...
4 months ago (2018-05-17 12:50:46 UTC) #60
kzar
LGTM https://codereview.adblockplus.org/29760704/diff/29784572/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29760704/diff/29784572/lib/filterClasses.js#newcode949 lib/filterClasses.js:949: let rewrittenUrl = new URL(url.replace(this.regexp, this.rewrite), url); I ...
4 months ago (2018-05-17 12:56:07 UTC) #61
hub
4 months ago (2018-05-17 12:58:39 UTC) #62
https://codereview.adblockplus.org/29760704/diff/29784572/lib/filterClasses.js
File lib/filterClasses.js (right):

https://codereview.adblockplus.org/29760704/diff/29784572/lib/filterClasses.j...
lib/filterClasses.js:949: let rewrittenUrl = new URL(url.replace(this.regexp,
this.rewrite), url);
On 2018/05/17 12:56:06, kzar wrote:
> I forgot to mention before, I thought how you did this part was clever. Just
> reusing the existing generated regexp.

thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5