Unified Diff: test/_common.js
Issue 29760704:
Issue 6592 - Implement $rewrite filter option (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Comment fixes.
Created May 11, 2018, 3:57 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« lib/filterClasses.js ('K')
|
« test/.eslintrc.json ('k')
|
test/filterClasses.js » ('j')
|
test/filterClasses.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/_common.js |
| =================================================================== |
| --- a/test/_common.js |
| +++ b/test/_common.js |
| @@ -26,21 +26,16 @@ |
| NS_BINDING_ABORTED: 0x804B0002, |
| NS_ERROR_FAILURE: 0x80004005 |
| }; |
| const MILLIS_IN_SECOND = exports.MILLIS_IN_SECOND = 1000; |
| const MILLIS_IN_MINUTE = exports.MILLIS_IN_MINUTE = 60 * MILLIS_IN_SECOND; |
| const MILLIS_IN_HOUR = exports.MILLIS_IN_HOUR = 60 * MILLIS_IN_MINUTE; |
| -function URL(urlString) |
|
kzar
2018/05/15 14:08:58
What's with this change?
hub
2018/05/15 16:16:31
This one is required: it was a polyfill for the UR
hub
2018/05/15 16:17:53
And I must add: this is only used in the tests.
kzar
2018/05/16 09:22:40
I think this was for Node.js 7 compatability which
Sebastian Noack
2018/05/16 10:53:29
I'm on Node.js 8.5, and there is no global URL obj
hub
2018/05/16 12:08:11
According to the documentation, it was added in No
Sebastian Noack
2018/05/16 12:13:22
Yes, the code here could be changed to:
const {
hub
2018/05/16 13:11:49
It is global in NodeJS 10.
See https://nodejs.org/
|
| -{ |
| - return require("url").parse(urlString); |
| -} |
| - |
| let Services = { |
| obs: { |
| addObserver() {} |
| } |
| }; |
| let XPCOMUtils = { |
| generateQI() {} |
| }; |
« lib/filterClasses.js ('K')
|
« test/.eslintrc.json ('k')
|
test/filterClasses.js » ('j')
|
test/filterClasses.js » ('J')
