Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29768690: Noissue - Compare individual characters instead of substring (Closed)

Created:
May 2, 2018, 11:36 p.m. by Manish Jethani
Modified:
May 4, 2018, 1:03 p.m.
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Compare individual characters instead of substring

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/matcher.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Manish Jethani
May 2, 2018, 11:37 p.m. (2018-05-02 23:37:04 UTC) #1
Manish Jethani
Patch Set 1 Turns out comparing individual characters is significantly faster on both V8 and ...
May 2, 2018, 11:39 p.m. (2018-05-02 23:39:00 UTC) #2
kzar
May 3, 2018, 4:06 p.m. (2018-05-03 16:06:42 UTC) #3
Nice, LGTM

Powered by Google App Engine
This is Rietveld