Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29770586: Issue 6670 - Display the rewritten to info if applicable in the devtools (Closed)

Created:
May 4, 2018, 6:28 p.m. by hub
Modified:
May 17, 2018, 5:30 p.m.
CC:
Manish Jethani, kzar
Base URL:
https://hg.adblockplus.org/adblockplusui/
Visibility:
Public.

Description

Issue 6670 - Display the rewritten to info if applicable in the devtools (this is for the changes in https://codereview.adblockplus.org/29760707/)

Patch Set 1 #

Total comments: 4

Patch Set 2 : HTML fixes. #

Total comments: 6

Patch Set 3 : Added Mock data. Use hidden attribute. Refactor CSS #

Total comments: 4

Patch Set 4 : Rename rewrittenTo to rewrittenUrl #

Patch Set 5 : Some CSS style fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M background.js View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M devtools-panel.html View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M devtools-panel.js View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M skin/devtools-panel.css View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9
hub
May 4, 2018, 6:28 p.m. (2018-05-04 18:28:29 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29770586/diff/29770587/devtools-panel.html File devtools-panel.html (right): https://codereview.adblockplus.org/29770586/diff/29770587/devtools-panel.html#newcode90 devtools-panel.html:90: <div><a class="resource-link" href="" target="_blank">&nbsp;</a> Nit: Put the <a> on ...
May 4, 2018, 6:54 p.m. (2018-05-04 18:54:24 UTC) #2
hub
updated patch https://codereview.adblockplus.org/29770586/diff/29770587/devtools-panel.html File devtools-panel.html (right): https://codereview.adblockplus.org/29770586/diff/29770587/devtools-panel.html#newcode90 devtools-panel.html:90: <div><a class="resource-link" href="" target="_blank">&nbsp;</a> On 2018/05/04 18:54:24, ...
May 4, 2018, 6:59 p.m. (2018-05-04 18:59:44 UTC) #3
Thomas Greiner
As mentioned in the ticket, I've requested approval from Product to make sure we're not ...
May 7, 2018, 5:20 p.m. (2018-05-07 17:20:29 UTC) #4
hub
Path updated https://codereview.adblockplus.org/29770586/diff/29770591/devtools-panel.html File devtools-panel.html (right): https://codereview.adblockplus.org/29770586/diff/29770591/devtools-panel.html#newcode1 devtools-panel.html:1: <!DOCTYPE html> On 2018/05/07 17:20:29, Thomas Greiner ...
May 7, 2018, 9:03 p.m. (2018-05-07 21:03:01 UTC) #5
hub
This to followup on a request in the WebExt review.
May 15, 2018, 4:29 p.m. (2018-05-15 16:29:49 UTC) #6
Thomas Greiner
The design got approved so only two small comments left to tackle. https://codereview.adblockplus.org/29770586/diff/29773612/skin/devtools-panel.css File skin/devtools-panel.css ...
May 17, 2018, 2:08 p.m. (2018-05-17 14:08:28 UTC) #7
hub
Patch updated. https://codereview.adblockplus.org/29770586/diff/29773612/skin/devtools-panel.css File skin/devtools-panel.css (right): https://codereview.adblockplus.org/29770586/diff/29773612/skin/devtools-panel.css#newcode182 skin/devtools-panel.css:182: .rewritten-to > a, .resource-link { On 2018/05/17 ...
May 17, 2018, 2:12 p.m. (2018-05-17 14:12:48 UTC) #8
Thomas Greiner
May 17, 2018, 2:46 p.m. (2018-05-17 14:46:30 UTC) #9 
LGTM

If you send me the patch I can then push it for you.

Powered by Google App Engine
This is Rietveld