Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: devtools-panel.html

Issue 29770586: Issue 6670 - Display the rewritten to info if applicable in the devtools (Closed) Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Created May 4, 2018, 6:28 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | devtools-panel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: devtools-panel.html
===================================================================
--- a/devtools-panel.html
+++ b/devtools-panel.html
@@ -82,17 +82,19 @@
<footer>
<a id="reload">Reload</a> page to see effect of filter changes
</footer>
<template>
<tr>
<td>
<div class="request-wrapper">
- <a class="resource-link" href="" target="_blank">&nbsp;</a>
+ <div><a class="resource-link" href="" target="_blank">&nbsp;</a>
Sebastian Noack 2018/05/04 18:54:24 Nit: Put the <a> on a new line and indent the line
hub 2018/05/04 18:59:43 Done.
+ <span class="rewritten-to" style="display:none;"> rewritten to <a href="" target="_blank"></a></span>
+ <div>
Sebastian Noack 2018/05/04 18:54:24 Is this meant to be </div> (closing)?
hub 2018/05/04 18:59:43 argh. yes.
<div class="domain"></div>
</div>
</td>
<td>
<div class="type"></div>
</td>
<td>
<div class="action-wrapper">
« no previous file with comments | « no previous file | devtools-panel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld