Issue 6647 - Stop converting domains from punycode to unicode

lib/options.js

Index: lib/options.js
===================================================================
--- a/lib/options.js
+++ b/lib/options.js
@@ -19,7 +19,6 @@
 
 "use strict";
 
-const {getDecodedHostname} = require("./url");
 const {checkWhitelisted} = require("./whitelisting");
 const info = require("../buildtools/info");
 
@@ -214,7 +213,7 @@
         action: "showPageOptions",
         args: [
           {
-            host: getDecodedHostname(currentPage.url).replace(/^www\./, ""),
+            host: currentPage.url.hostname.replace(/^www\./, ""),

[Manish Jethani, 2018/05/06 18:37:13]

Should we also display the encoded hostname in the UI? Maybe this is a case
where it would still be a good idea to display the Unicode version of the name.

[Sebastian Noack, 2018/05/06 18:47:40]

Whatever we do here, it will be inconsistent with what the browser shows in the
address bar. Firefox and Chrome apply different heuristics to determine whether
to render the domain in the URL in the address bar as unicode (or to show the
raw punycode). Ideally, we would use the same representation as in the address
bar but that isn't possible. Also note that this is only for the mobile options
page in Firefox on Android. Also keep in mind that we would have to keep the
punycode library included in the repository and the builds just for this.

[Manish Jethani, 2018/05/07 17:03:45]

I remember when I was testing ABP on Firefox for Android it was neat to see the
domain i❤️.ws appear on the options page. I don't even remember if it's
displayed like that in the address bar. Anyway, I'm OK with this change.

             whitelisted: !!checkWhitelisted(currentPage)
           }
         ]