Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 29773630: Issue 5761 - Changes require paths to relative

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by Jon Sonesen
Modified:
2 days, 13 hours ago
Base URL:
https://hg.adblockplus.org/adblockplusui/
Visibility:
Public.

Description

Issue 5761 - Changes require paths to relative

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address PS1 comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M background.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/antiadblockInit.js View 1 chunk +6 lines, -6 lines 0 comments Download
M messageResponder.js View 1 4 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 4
Jon Sonesen
1 week, 6 days ago (2018-05-08 01:03:37 UTC) #1
Jon Sonesen
https://codereview.adblockplus.org/29773630/diff/29773631/background.js File background.js (right): https://codereview.adblockplus.org/29773630/diff/29773631/background.js#newcode93 background.js:93: return modules[module.substr(module.lastIndexOf("/") + 1)]; this is a bit hacky ...
1 week, 6 days ago (2018-05-08 01:04:26 UTC) #2
kzar
https://codereview.adblockplus.org/29773630/diff/29773631/messageResponder.js File messageResponder.js (right): https://codereview.adblockplus.org/29773630/diff/29773631/messageResponder.js#newcode40 messageResponder.js:40: const info = require("../buildtools/info"); It turns out using a ...
3 days, 17 hours ago (2018-05-17 13:53:28 UTC) #3
Jon Sonesen
2 days, 13 hours ago (2018-05-18 17:18:12 UTC) #4
On 2018/05/17 13:53:28, kzar wrote:
> https://codereview.adblockplus.org/29773630/diff/29773631/messageResponder.js
> File messageResponder.js (right):
> 
>
https://codereview.adblockplus.org/29773630/diff/29773631/messageResponder.js...
> messageResponder.js:40: const info = require("../buildtools/info");
> It turns out using a relative path for the info module is a bad idea, it
caused
> problems for the AdBlock guys (see #6675). Please could you leave this one as
> `const info = require("info");`?

Ack
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5