Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(588)

Issue 29773630: Issue 5761 - Changes require paths to relative

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 2 weeks ago by Jon Sonesen
Modified:
1 month, 2 weeks ago
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockplusui/
Visibility:
Public.

Description

Issue 5761 - Change module paths to be relative

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address PS1 comment #

Total comments: 4

Patch Set 3 : Address PS2 comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M background.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/antiadblockInit.js View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M messageResponder.js View 1 2 1 chunk +14 lines, -13 lines 0 comments Download

Messages

Total messages: 12
Jon Sonesen
4 months, 2 weeks ago (2018-05-08 01:03:37 UTC) #1
Jon Sonesen
https://codereview.adblockplus.org/29773630/diff/29773631/background.js File background.js (right): https://codereview.adblockplus.org/29773630/diff/29773631/background.js#newcode93 background.js:93: return modules[module.substr(module.lastIndexOf("/") + 1)]; this is a bit hacky ...
4 months, 2 weeks ago (2018-05-08 01:04:26 UTC) #2
kzar
https://codereview.adblockplus.org/29773630/diff/29773631/messageResponder.js File messageResponder.js (right): https://codereview.adblockplus.org/29773630/diff/29773631/messageResponder.js#newcode40 messageResponder.js:40: const info = require("../buildtools/info"); It turns out using a ...
4 months ago (2018-05-17 13:53:28 UTC) #3
Jon Sonesen
On 2018/05/17 13:53:28, kzar wrote: > https://codereview.adblockplus.org/29773630/diff/29773631/messageResponder.js > File messageResponder.js (right): > > https://codereview.adblockplus.org/29773630/diff/29773631/messageResponder.js#newcode40 > ...
4 months ago (2018-05-18 17:18:12 UTC) #4
kzar
On 2018/05/18 17:18:12, Jon Sonesen wrote: > Ack Thanks
4 months ago (2018-05-22 12:43:49 UTC) #5
a.giammarchi
a minor note on the name resolution just because I've read kzar note. If that's ...
2 months, 2 weeks ago (2018-07-02 08:14:26 UTC) #6
Jon Sonesen
https://codereview.adblockplus.org/29773630/diff/29785577/background.js File background.js (right): https://codereview.adblockplus.org/29773630/diff/29785577/background.js#newcode93 background.js:93: return modules[module.substr(module.lastIndexOf("/") + 1)]; On 2018/07/02 08:14:26, a.giammarchi wrote: ...
2 months, 1 week ago (2018-07-09 19:23:49 UTC) #7
Thomas Greiner
https://codereview.adblockplus.org/29773630/diff/29785577/background.js File background.js (right): https://codereview.adblockplus.org/29773630/diff/29785577/background.js#newcode93 background.js:93: return modules[module.substr(module.lastIndexOf("/") + 1)]; On 2018/07/09 19:23:49, Jon Sonesen ...
1 month, 3 weeks ago (2018-07-26 10:08:00 UTC) #8
a.giammarchi
On 2018/07/26 10:08:00, Thomas Greiner wrote: > https://codereview.adblockplus.org/29773630/diff/29785577/background.js > File background.js (right): > > https://codereview.adblockplus.org/29773630/diff/29785577/background.js#newcode93 ...
1 month, 3 weeks ago (2018-07-26 10:24:41 UTC) #9
Jon Sonesen
On 2018/07/26 10:24:41, a.giammarchi wrote: > On 2018/07/26 10:08:00, Thomas Greiner wrote: > > https://codereview.adblockplus.org/29773630/diff/29785577/background.js ...
1 month, 3 weeks ago (2018-07-27 01:16:52 UTC) #10
a.giammarchi
On 2018/07/27 01:16:52, Jon Sonesen wrote: > > I think doing this would not be ...
1 month, 3 weeks ago (2018-07-27 06:28:51 UTC) #11
Thomas Greiner
1 month, 3 weeks ago (2018-07-27 09:30:35 UTC) #12
I agree that there's probably no need to block this change because of that.
However, in case it turns out that it's not much extra work, it'd be a nice
change to include.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5