Issue 6586 - Handle intiator of "null" on Chrome >=66

Issue 6586 - Handle intiator of "null" on Chrome >=66

[Sebastian Noack, 2018-05-10 15:41:40]

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js
File lib/requestBlocker.js (right):

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker....
lib/requestBlocker.js:186: // an "initiator", this implies a request sent by the
browser itself
Just fixed a typo here.

[kzar, 2018-05-11 12:50:17]

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js
File lib/requestBlocker.js (right):

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker....
lib/requestBlocker.js:115: else if (details.initiator && details.initiator !=
"null")
Why are you comparing it to the string "null" instead of null?

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker....
lib/requestBlocker.js:186: // an "initiator", this implies a request sent by the
browser itself
On 2018/05/10 15:41:40, Sebastian Noack wrote:
> Just fixed a typo here.

Acknowledged.

[Sebastian Noack, 2018-05-11 12:52:40]

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js
File lib/requestBlocker.js (right):

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker....
lib/requestBlocker.js:115: else if (details.initiator && details.initiator !=
"null")
On 2018/05/11 12:50:17, kzar wrote:
> Why are you comparing it to the string "null" instead of null?

Because that is what Chrome >=66 sets the value to if unknown.

[kzar, 2018-05-11 12:58:56]

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js
File lib/requestBlocker.js (right):

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker....
lib/requestBlocker.js:115: else if (details.initiator && details.initiator !=
"null")
On 2018/05/11 12:52:40, Sebastian Noack wrote:
> On 2018/05/11 12:50:17, kzar wrote:
> > Why are you comparing it to the string "null" instead of null?
> 
> Because that is what Chrome >=66 sets the value to if unknown.

Weird, that sounds like a bug, did you report it?

[Sebastian Noack, 2018-05-11 13:04:44]

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js
File lib/requestBlocker.js (right):

https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker....
lib/requestBlocker.js:115: else if (details.initiator && details.initiator !=
"null")
On 2018/05/11 12:58:56, kzar wrote:
> On 2018/05/11 12:52:40, Sebastian Noack wrote:
> > On 2018/05/11 12:50:17, kzar wrote:
> > > Why are you comparing it to the string "null" instead of null?
> > 
> > Because that is what Chrome >=66 sets the value to if unknown.
> 
> Weird, that sounds like a bug, did you report it?

Well, that behavior matches the documentation:
https://developer.chrome.com/extensions/webRequest#property-details-initiator

[kzar, 2018-05-11 13:12:36]

Weird, well fair enough. LGTM