Issue 6596 - update to work with v8 6.7.288.11

Since building of V8 takes ages and consumes a lot of space (~20 GB) and requires additional tools, that procedure was eliminated from libadblockplus project. The only non-trivial part of building V8 is the configuration described in args.gn, one can find all necessary files in v8-args directory.

Additionally there no a strict requirement of a particular V8 version anymore. E.g. currently the code is compatible with a set of V8 versions, presumably between 6.5 and 6.7.

[sergei, 2018-05-16 10:38:24]

The script to build and pack V8, possibly with CI configurations, will be done
under hub#11227. If someone needs it already please let me know, I have the
script and used it to obtain all binaries for the CI touched in this codereview.

@anton, please take into account that libadblockplus does not build V8 anymore,
and it will be done in v8-project. Additionally we need to sync and I will add
the target to build only libadblockplus library, so you have to specify only V8
include directory for libadblockplus. I expect that it will simplify the build
of other projects, namely there will not be a need in copying of the V8
directories.

[anton, 2018-05-16 10:40:32]

On 2018/05/16 10:38:24, sergei wrote:
> @anton, please take into account that libadblockplus does not build V8
anymore,
> and it will be done in v8-project. Additionally we need to sync and I will add
> the target to build only libadblockplus library, so you have to specify only
V8
> include directory for libadblockplus. I expect that it will simplify the build
> of other projects, namely there will not be a need in copying of the V8
> directories.

yes, i got this.

[hub, 2018-05-23 18:27:05]

https://codereview.adblockplus.org/29783566/diff/29783567/README.md
File README.md (right):

https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52
README.md:52: LIBV8_LIB_DIR.
it would be nice to have directions to optionally get the prebuilts.

Or better a script that does what the .travis/prepare-prebuilt-v8.sh script
does, but for the local build.

https://codereview.adblockplus.org/29783566/diff/29783567/include/AdblockPlus...
File include/AdblockPlus/JsEngine.h (right):

https://codereview.adblockplus.org/29783566/diff/29783567/include/AdblockPlus...
include/AdblockPlus/JsEngine.h:42: typedef void(*FunctionCallback)(const
FunctionCallbackInfo<Value>& info);
Nit: is this change *needed* here, or was just a drive by?

[anton, 2018-05-24 07:41:55]

https://codereview.adblockplus.org/29783566/diff/29783567/README.md
File README.md (right):

https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52
README.md:52: LIBV8_LIB_DIR.
On 2018/05/23 18:27:05, hub wrote:
> it would be nice to have directions to optionally get the prebuilts.
> 
> Or better a script that does what the .travis/prepare-prebuilt-v8.sh script
> does, but for the local build.

yes, i completely agree.
It can be unclear on what's version of v8 can be used (i'd suggest to write
about it in README too),
how can it be downloaded/built (required targeting to the same ARCH while
building v8 and libadblockplus), etc.
Also i believe it could be very useful to provide precompiled v8 just like we do
for 'libadblockplus-binaries'.

[sergei, 2018-05-24 08:45:43]

https://codereview.adblockplus.org/29783566/diff/29783567/README.md
File README.md (right):

https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52
README.md:52: LIBV8_LIB_DIR.
On 2018/05/24 07:41:55, anton wrote:
> On 2018/05/23 18:27:05, hub wrote:
> > it would be nice to have directions to optionally get the prebuilts.
> > 
> > Or better a script that does what the .travis/prepare-prebuilt-v8.sh script
> > does, but for the local build.
> 
> yes, i completely agree.
> It can be unclear on what's version of v8 can be used (i'd suggest to write
> about it in README too),
> how can it be downloaded/built (required targeting to the same ARCH while
> building v8 and libadblockplus), etc.
> Also i believe it could be very useful to provide precompiled v8 just like we
do
> for 'libadblockplus-binaries'.

That's all right but can we do it in the following steps?

I deliberately didn't include the version of V8 because now there is no strict
connection to a particular version. Here is the issue in that regard
https://issues.adblockplus.org/ticket/6694.

Regarding the binaries I have filed the issue
https://issues.adblockplus.org/ticket/6695.

https://codereview.adblockplus.org/29783566/diff/29783567/include/AdblockPlus...
File include/AdblockPlus/JsEngine.h (right):

https://codereview.adblockplus.org/29783566/diff/29783567/include/AdblockPlus...
include/AdblockPlus/JsEngine.h:42: typedef void(*FunctionCallback)(const
FunctionCallbackInfo<Value>& info);
On 2018/05/23 18:27:05, hub wrote:
> Nit: is this change *needed* here, or was just a drive by?

It is needed. I was also surprised, but otherwise there is a compilation error.

[hub, 2018-05-24 12:29:51]

https://codereview.adblockplus.org/29783566/diff/29783567/README.md
File README.md (right):

https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52
README.md:52: LIBV8_LIB_DIR.
On 2018/05/24 08:45:42, sergei wrote:
> On 2018/05/24 07:41:55, anton wrote:
> > On 2018/05/23 18:27:05, hub wrote:
> > > it would be nice to have directions to optionally get the prebuilts.
> > > 
> > > Or better a script that does what the .travis/prepare-prebuilt-v8.sh
script
> > > does, but for the local build.
> > 
> > yes, i completely agree.
> > It can be unclear on what's version of v8 can be used (i'd suggest to write
> > about it in README too),
> > how can it be downloaded/built (required targeting to the same ARCH while
> > building v8 and libadblockplus), etc.
> > Also i believe it could be very useful to provide precompiled v8 just like
we
> do
> > for 'libadblockplus-binaries'.
> 
> That's all right but can we do it in the following steps?
> 
> I deliberately didn't include the version of V8 because now there is no strict
> connection to a particular version. Here is the issue in that regard
> https://issues.adblockplus.org/ticket/6694.
> 
> Regarding the binaries I have filed the issue
> https://issues.adblockplus.org/ticket/6695.
> 

There is somewhat a connection. I tried to build on macOS with the v8 provided
by Homebrew and it didn't work because it was too old. (just building for macOS)

https://codereview.adblockplus.org/29783566/diff/29783567/include/AdblockPlus...
File include/AdblockPlus/JsEngine.h (right):

https://codereview.adblockplus.org/29783566/diff/29783567/include/AdblockPlus...
include/AdblockPlus/JsEngine.h:42: typedef void(*FunctionCallback)(const
FunctionCallbackInfo<Value>& info);
On 2018/05/24 08:45:42, sergei wrote:
> On 2018/05/23 18:27:05, hub wrote:
> > Nit: is this change *needed* here, or was just a drive by?
> 
> It is needed. I was also surprised, but otherwise there is a compilation
error.

Acknowledged.

[sergei, 2018-05-25 10:05:24]

https://codereview.adblockplus.org/29783566/diff/29783567/README.md
File README.md (right):

https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52
README.md:52: LIBV8_LIB_DIR.
On 2018/05/24 12:29:51, hub wrote:
> On 2018/05/24 08:45:42, sergei wrote:
> > On 2018/05/24 07:41:55, anton wrote:
> > > On 2018/05/23 18:27:05, hub wrote:
> > > > it would be nice to have directions to optionally get the prebuilts.
> > > > 
> > > > Or better a script that does what the .travis/prepare-prebuilt-v8.sh
> script
> > > > does, but for the local build.
> > > 
> > > yes, i completely agree.
> > > It can be unclear on what's version of v8 can be used (i'd suggest to
write
> > > about it in README too),
> > > how can it be downloaded/built (required targeting to the same ARCH while
> > > building v8 and libadblockplus), etc.
> > > Also i believe it could be very useful to provide precompiled v8 just like
> we
> > do
> > > for 'libadblockplus-binaries'.
> > 
> > That's all right but can we do it in the following steps?
> > 
> > I deliberately didn't include the version of V8 because now there is no
strict
> > connection to a particular version. Here is the issue in that regard
> > https://issues.adblockplus.org/ticket/6694.
> > 
> > Regarding the binaries I have filed the issue
> > https://issues.adblockplus.org/ticket/6695.
> > 
> 
> There is somewhat a connection. I tried to build on macOS with the v8 provided
> by Homebrew and it didn't work because it was too old. (just building for
macOS)

I have added the mentioning of the V8 version in the readme file.

[hub, 2018-05-25 12:52:16]

My point here is that we move from "just build" to "figure out things and
eventually build". If at least we had the option to setup v8 the same way it is
done on travis without guess work.

[sergei, 2018-05-25 13:03:55]

On 2018/05/25 12:52:16, hub wrote:
> My point here is that we move from "just build" to "figure out things and
> eventually build". If at least we had the option to setup v8 the same way it
is
> done on travis without guess work.

Yeah, I got it, but can it be done separately as
https://issues.adblockplus.org/ticket/6695?

[hub, 2018-05-25 15:43:54]

LGTM

[sergei, 2018-05-28 09:34:00]

On 2018/05/25 15:43:54, hub wrote:
> LGTM

I will wait for a while (a couple of days), perhaps we can manage to create the
repository #11227 (Hub), because honestly it's a bit unfair to completely drop
the stage of building of V8.