Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 29783566: Issue 6596 - update to work with v8 6.7.288.11

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 21 hours ago by sergei
Modified:
2 days, 11 hours ago
Reviewers:
anton, Oleksandr, hub
Base URL:
https://github.com/adblockplus/libadblockplus@99836840e314b7941fdb51cb2b91f23ca3ee3414
Visibility:
Public.

Description

Since building of V8 takes ages and consumes a lot of space (~20 GB) and requires additional tools, that procedure was eliminated from libadblockplus project. The only non-trivial part of building V8 is the configuration described in args.gn, one can find all necessary files in v8-args directory. Additionally there no a strict requirement of a particular V8 version anymore. E.g. currently the code is compatible with a set of V8 versions, presumably between 6.5 and 6.7.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -321 lines) Patch
M .travis.yml View 1 chunk +9 lines, -9 lines 0 comments Download
M .travis/prepare-prebuilt-v8.sh View 1 chunk +5 lines, -9 lines 0 comments Download
M Makefile View 3 chunks +37 lines, -90 lines 0 comments Download
M README.md View 5 chunks +42 lines, -35 lines 0 comments Download
D android-v8-options.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
M appveyor.yml View 1 chunk +2 lines, -3 lines 0 comments Download
D build-v8.cmd View 1 chunk +0 lines, -21 lines 0 comments Download
D build-v8.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
M dependencies View 1 chunk +0 lines, -7 lines 0 comments Download
M include/AdblockPlus/JsEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/v8_gyp_launcher View 1 chunk +0 lines, -9 lines 0 comments Download
M v8.gypi View 1 chunk +10 lines, -67 lines 0 comments Download
A v8-args/args-android-arm-release View 1 chunk +13 lines, -0 lines 0 comments Download
A v8-args/args-android-arm64-release View 1 chunk +13 lines, -0 lines 0 comments Download
A v8-args/args-android-ia32-release View 1 chunk +13 lines, -0 lines 0 comments Download
A v8-args/args-linux-x64-debug View 1 chunk +12 lines, -0 lines 0 comments Download
A v8-args/args-osx-x64-debug View 1 chunk +12 lines, -0 lines 0 comments Download
A v8-args/args-win-ia32-debug View 1 chunk +12 lines, -0 lines 0 comments Download
A v8-args/args-win-ia32-release View 1 chunk +11 lines, -0 lines 0 comments Download
A v8-args/args-win-x64-debug View 1 chunk +12 lines, -0 lines 0 comments Download
A v8-args/args-win-x64-release View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2
sergei
The script to build and pack V8, possibly with CI configurations, will be done under ...
4 days, 20 hours ago (2018-05-16 10:38:24 UTC) #1
anton
4 days, 20 hours ago (2018-05-16 10:40:32 UTC) #2
On 2018/05/16 10:38:24, sergei wrote:
> @anton, please take into account that libadblockplus does not build V8
anymore,
> and it will be done in v8-project. Additionally we need to sync and I will add
> the target to build only libadblockplus library, so you have to specify only
V8
> include directory for libadblockplus. I expect that it will simplify the build
> of other projects, namely there will not be a need in copying of the V8
> directories.

yes, i got this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5