Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(553)

Issue 29783566: Issue 6596 - update to work with v8 6.7.288.11 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by sergei
Modified:
3 months, 1 week ago
Reviewers:
Oleksandr, anton, hub
Base URL:
https://github.com/adblockplus/libadblockplus@99836840e314b7941fdb51cb2b91f23ca3ee3414
Visibility:
Public.

Description

Since building of V8 takes ages and consumes a lot of space (~20 GB) and requires additional tools, that procedure was eliminated from libadblockplus project. The only non-trivial part of building V8 is the configuration described in args.gn, one can find all necessary files in v8-args directory. Additionally there no a strict requirement of a particular V8 version anymore. E.g. currently the code is compatible with a set of V8 versions, presumably between 6.5 and 6.7.

Patch Set 1 #

Total comments: 8

Patch Set 2 : mention the version of V8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -321 lines) Patch
M .travis.yml View 1 chunk +9 lines, -9 lines 0 comments Download
M .travis/prepare-prebuilt-v8.sh View 1 chunk +5 lines, -9 lines 0 comments Download
M Makefile View 3 chunks +37 lines, -90 lines 0 comments Download
M README.md View 1 5 chunks +44 lines, -35 lines 0 comments Download
D android-v8-options.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
M appveyor.yml View 1 chunk +2 lines, -3 lines 0 comments Download
D build-v8.cmd View 1 chunk +0 lines, -21 lines 0 comments Download
D build-v8.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
M dependencies View 1 chunk +0 lines, -7 lines 0 comments Download
M include/AdblockPlus/JsEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/v8_gyp_launcher View 1 chunk +0 lines, -9 lines 0 comments Download
M v8.gypi View 1 chunk +10 lines, -67 lines 0 comments Download
A v8-args/args-android-arm-release View 1 chunk +13 lines, -0 lines 0 comments Download
A v8-args/args-android-arm64-release View 1 chunk +13 lines, -0 lines 0 comments Download
A v8-args/args-android-ia32-release View 1 chunk +13 lines, -0 lines 0 comments Download
A v8-args/args-linux-x64-debug View 1 chunk +12 lines, -0 lines 0 comments Download
A v8-args/args-osx-x64-debug View 1 chunk +12 lines, -0 lines 0 comments Download
A v8-args/args-win-ia32-debug View 1 chunk +12 lines, -0 lines 0 comments Download
A v8-args/args-win-ia32-release View 1 chunk +11 lines, -0 lines 0 comments Download
A v8-args/args-win-x64-debug View 1 chunk +12 lines, -0 lines 0 comments Download
A v8-args/args-win-x64-release View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11
sergei
The script to build and pack V8, possibly with CI configurations, will be done under ...
4 months ago (2018-05-16 10:38:24 UTC) #1
anton
On 2018/05/16 10:38:24, sergei wrote: > @anton, please take into account that libadblockplus does not ...
4 months ago (2018-05-16 10:40:32 UTC) #2
hub
https://codereview.adblockplus.org/29783566/diff/29783567/README.md File README.md (right): https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52 README.md:52: LIBV8_LIB_DIR. it would be nice to have directions to ...
3 months, 4 weeks ago (2018-05-23 18:27:05 UTC) #3
anton
https://codereview.adblockplus.org/29783566/diff/29783567/README.md File README.md (right): https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52 README.md:52: LIBV8_LIB_DIR. On 2018/05/23 18:27:05, hub wrote: > it would ...
3 months, 4 weeks ago (2018-05-24 07:41:55 UTC) #4
sergei
https://codereview.adblockplus.org/29783566/diff/29783567/README.md File README.md (right): https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52 README.md:52: LIBV8_LIB_DIR. On 2018/05/24 07:41:55, anton wrote: > On 2018/05/23 ...
3 months, 4 weeks ago (2018-05-24 08:45:43 UTC) #5
hub
https://codereview.adblockplus.org/29783566/diff/29783567/README.md File README.md (right): https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52 README.md:52: LIBV8_LIB_DIR. On 2018/05/24 08:45:42, sergei wrote: > On 2018/05/24 ...
3 months, 4 weeks ago (2018-05-24 12:29:51 UTC) #6
sergei
https://codereview.adblockplus.org/29783566/diff/29783567/README.md File README.md (right): https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52 README.md:52: LIBV8_LIB_DIR. On 2018/05/24 12:29:51, hub wrote: > On 2018/05/24 ...
3 months, 3 weeks ago (2018-05-25 10:05:24 UTC) #7
hub
My point here is that we move from "just build" to "figure out things and ...
3 months, 3 weeks ago (2018-05-25 12:52:16 UTC) #8
sergei
On 2018/05/25 12:52:16, hub wrote: > My point here is that we move from "just ...
3 months, 3 weeks ago (2018-05-25 13:03:55 UTC) #9
hub
LGTM
3 months, 3 weeks ago (2018-05-25 15:43:54 UTC) #10
sergei
3 months, 3 weeks ago (2018-05-28 09:34:00 UTC) #11
On 2018/05/25 15:43:54, hub wrote:
> LGTM

I will wait for a while (a couple of days), perhaps we can manage to create the
repository #11227 (Hub), because honestly it's a bit unfair to completely drop
the stage of building of V8.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5