Issue 29783618: Issue 6665 - Split out element hiding exceptions into their own module

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29783618: Issue 6665 - Split out element hiding exceptions into their own module (Closed)

Created:
May 17, 2018, 3:46 a.m. by Manish Jethani

Modified:
Aug. 15, 2018, 7:28 p.m.

Reviewers:
kzar, hub

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

This is the first of a series of patches to share the functionality and optimizations in ElemHide with ElemHideEmulation as well as the new Snippets module. Both ElemHide and ElemHideEmulation use the same exception type, as will Snippets. This patch separates out the exceptions-related code into its own module, which ElemHide and ElemHideEmulation call into.

Patch Set 1 #

Patch Set 2 : Emit own elemhideupdate event #

Total comments: 3

Patch Set 3 : Rebase #

Patch Set 4 : Add lib/elemHideExceptions.js #

Created: Aug. 7, 2018, 2:18 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -94 lines)			Patch
M	lib/elemHide.js	View	1 2	6 chunks	+23 lines, -67 lines	0 comments	Download
M	lib/elemHideEmulation.js	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
A	lib/elemHideExceptions.js	View	1 2 3	1 chunk	+130 lines, -0 lines	0 comments	Download
M	lib/filterListener.js	View	1 2	4 chunks	+11 lines, -5 lines	0 comments	Download
M	test/elemHide.js	View	1 2	5 chunks	+13 lines, -7 lines	0 comments	Download
M	test/elemHideEmulation.js	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/filterListener.js	View	1 2	2 chunks	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Manish Jethani

Patch Set 1 Patch Set 2: Emit own elemhideupdate event https://codereview.adblockplus.org/29783618/diff/29784561/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29783618/diff/29784561/lib/elemHide.js#newcode58 ...

May 17, 2018, 5:42 a.m. (2018-05-17 05:42:48 UTC) #2

LGTM

Expand All Messages | Collapse All Messages