Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(314)

Issue 29783618: Issue 6665 - Split out element hiding exceptions into their own module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by Manish Jethani
Modified:
2 months ago
Reviewers:
kzar, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

This is the first of a series of patches to share the functionality and optimizations in ElemHide with ElemHideEmulation as well as the new Snippets module. Both ElemHide and ElemHideEmulation use the same exception type, as will Snippets. This patch separates out the exceptions-related code into its own module, which ElemHide and ElemHideEmulation call into.

Patch Set 1 #

Patch Set 2 : Emit own elemhideupdate event #

Total comments: 3

Patch Set 3 : Rebase #

Patch Set 4 : Add lib/elemHideExceptions.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -94 lines) Patch
M lib/elemHide.js View 1 2 6 chunks +23 lines, -67 lines 0 comments Download
M lib/elemHideEmulation.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A lib/elemHideExceptions.js View 1 2 3 1 chunk +130 lines, -0 lines 0 comments Download
M lib/filterListener.js View 1 2 4 chunks +11 lines, -5 lines 0 comments Download
M test/elemHide.js View 1 2 5 chunks +13 lines, -7 lines 0 comments Download
M test/elemHideEmulation.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/filterListener.js View 1 2 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
5 months ago (2018-05-17 03:47:00 UTC) #1
Manish Jethani
Patch Set 1 Patch Set 2: Emit own elemhideupdate event https://codereview.adblockplus.org/29783618/diff/29784561/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29783618/diff/29784561/lib/elemHide.js#newcode58 ...
5 months ago (2018-05-17 05:42:48 UTC) #2
Manish Jethani
Patch Set 3: Rebase
2 months, 1 week ago (2018-08-07 14:17:07 UTC) #3
Manish Jethani
Patch Set 4: Add lib/elemHideExceptions.js
2 months, 1 week ago (2018-08-07 14:18:50 UTC) #4
hub
2 months ago (2018-08-15 19:15:05 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5