Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(604)

Issue 29784555: Issue 6665 - Abstract element hiding container logic into its own module

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by Manish Jethani
Modified:
3 weeks, 6 days ago
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Based on https://codereview.adblockplus.org/29783618/ This patch separates out common functionality between ElemHide and ElemHideEmulation into a separate "ContentFilterModule" object (which will also work for Snippets eventually). It does not yet make ElemHideEmulation take advantage of the optimizations in ElemHide, that will be a follow-up patch.

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 3

Patch Set 3 : Rebase #

Patch Set 4 : Move base class into lib/contentFilterModule.js #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -177 lines) Patch
A lib/contentFilterModule.js View 1 2 3 1 chunk +201 lines, -0 lines 1 comment Download
M lib/elemHide.js View 1 2 3 3 chunks +14 lines, -138 lines 0 comments Download
M lib/elemHideEmulation.js View 1 2 3 1 chunk +4 lines, -34 lines 0 comments Download
M test/filterListener.js View 1 2 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
4 months ago (2018-05-17 05:16:05 UTC) #1
Manish Jethani
Patch Set 1 Patch Set 2: Rebase Based on https://codereview.adblockplus.org/29783618/ https://codereview.adblockplus.org/29784555/diff/29784568/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29784555/diff/29784568/lib/elemHide.js#newcode214 ...
4 months ago (2018-05-17 05:51:55 UTC) #2
Manish Jethani
Patch Set 3: Rebase Patch Set 4: Move base class into lib/contentFilterModule.js Note that the ...
1 month ago (2018-08-15 21:02:53 UTC) #3
hub
3 weeks, 6 days ago (2018-08-23 16:05:39 UTC) #4
https://codereview.adblockplus.org/29784555/diff/29856580/lib/contentFilterMo...
File lib/contentFilterModule.js (right):

https://codereview.adblockplus.org/29784555/diff/29856580/lib/contentFilterMo...
lib/contentFilterModule.js:134: this._knownFilters])
I'd be for using forEach() here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5