Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: adblock-android/AndroidManifest.xml

Issue 29784577: Issue 6205 - Upload artifacs to maven repository (Closed)
Left Patch Set: Several adjustments Created July 9, 2018, 3:53 p.m.
Right Patch Set: Adjustments regarding comments Created July 10, 2018, 12:39 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « adblock-android-webviewapp/build.gradle ('k') | adblock-android/build.gradle » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <manifest xmlns:android="http://schemas.android.com/apk/res/android" 2 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
3 package="org.adblockplus.libadblockplus"> 3 package="org.adblockplus.libadblockplus">
4 4
5 <uses-sdk 5 <uses-sdk
6 android:minSdkVersion="16" 6 android:minSdkVersion="16"
7 android:targetSdkVersion="16" /> 7 android:targetSdkVersion="16" />
8 8
9 <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/> 9 <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
anton 2018/07/10 09:51:39 Unrelated change. It's mentioned in README that e
jens 2018/07/10 10:08:10 I always prefer to not add permissions in the libr
diegocarloslima 2018/07/10 12:26:02 As explained through IRC, this change is not unrel
10 <uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>
10 11
11 </manifest> 12 </manifest>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld