adblock-android/AndroidManifest.xml - Issue 29784577: Issue 6205 - Upload artifacs to maven repository

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: adblock-android/AndroidManifest.xml

Issue 29784577: Issue 6205 - Upload artifacs to maven repository (Closed)

Left Patch Set: Several adjustments Created July 9, 2018, 3:53 p.m.

Right Patch Set: Adjustments regarding comments Created July 10, 2018, 12:39 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <manifest xmlns:android="http://schemas.android.com/apk/res/android"	2 <manifest xmlns:android="http://schemas.android.com/apk/res/android"

3 package="org.adblockplus.libadblockplus">	3 package="org.adblockplus.libadblockplus">

4	4

5 <uses-sdk	5 <uses-sdk

6 android:minSdkVersion="16"	6 android:minSdkVersion="16"

7 android:targetSdkVersion="16" />	7 android:targetSdkVersion="16" />

8	8

9 <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>	9 <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
anton 2018/07/10 09:51:39 Unrelated change. It's mentioned in README that e Unrelated change. It's mentioned in README that end-user app should add according permissions. If we want to simplify end-user app developers life then we should add the 2nd permission too. Previously it was not merged i believe (permissions from lib aars to apk). jens 2018/07/10 10:08:10 I always prefer to not add permissions in the libr I always prefer to not add permissions in the library, but to add them myself in the app project. diegocarloslima 2018/07/10 12:26:02 As explained through IRC, this change is not unrel Show quoted text On 2018/07/10 10:08:10, jens wrote: > I always prefer to not add permissions in the library, but to add them myself in > the app project. As explained through IRC, this change is not unrelated, since the bintrayUpload task runs the lint task, which throws an error due to this missing permission. I will also add the other permission, to make it consistent
	10 <uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>

10	11

11 </manifest>	12 </manifest>

LEFT	RIGHT