Issue 6205 - Upload artifacs to maven repository

Issue 6205 - Upload artifacs to maven repository

[diegocarloslima, 2018-05-17 13:45:48]

https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/And...
File adblock-android/AndroidManifest.xml (right):

https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/And...
adblock-android/AndroidManifest.xml:9: <uses-permission
android:name="android.permission.ACCESS_NETWORK_STATE"/>
The lack of this permission was causing an lint error when running bintrayUpload

https://codereview.adblockplus.org/29784577/diff/29784578/build.gradle
File build.gradle (right):

https://codereview.adblockplus.org/29784577/diff/29784578/build.gradle#newcode38
build.gradle:38: bintrayUserOrg = 'adblockplus'
We still need to discuss what will be our organization in Bintray. If it will be
'adblockplus' or 'eyeo' or even something else.

https://codereview.adblockplus.org/29784577/diff/29784578/build.gradle#newcode39
build.gradle:39: bintrayGroupId = 'org.adblockplus'
I think that for the group id is fine if we strip down the '.libadblockplus'
part of the package

https://codereview.adblockplus.org/29784577/diff/29784578/gradle/wrapper/grad...
File gradle/wrapper/gradle-wrapper.properties (right):

https://codereview.adblockplus.org/29784577/diff/29784578/gradle/wrapper/grad...
gradle/wrapper/gradle-wrapper.properties:5:
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
bintray-release requires Gradle 4.1+

[anton, 2018-05-21 19:50:51]

https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
File adblock-android/build.gradle (right):

https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
adblock-android/build.gradle:72: }
I think we need to add section to README describing on how to use artifacts from
bintray for Gradle (and may be maven).

[diegocarloslima, 2018-06-04 20:41:20]

https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
File adblock-android/build.gradle (right):

https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
adblock-android/build.gradle:72: }
On 2018/05/21 19:50:51, anton wrote:
> I think we need to add section to README describing on how to use artifacts
from
> bintray for Gradle (and may be maven).

Acknowledged.

[anton, 2018-07-02 10:06:32]

On 2018/06/04 20:41:20, diegocarloslima wrote:
>
https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
> File adblock-android/build.gradle (right):
> 
>
https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
> adblock-android/build.gradle:72: }
> On 2018/05/21 19:50:51, anton wrote:
> > I think we need to add section to README describing on how to use artifacts
> from
> > bintray for Gradle (and may be maven).
> 
> Acknowledged.

Any update?

[diegocarloslima, 2018-07-03 09:22:06]

On 2018/07/02 10:06:32, anton wrote:
> On 2018/06/04 20:41:20, diegocarloslima wrote:
> >
>
https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
> > File adblock-android/build.gradle (right):
> > 
> >
>
https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
> > adblock-android/build.gradle:72: }
> > On 2018/05/21 19:50:51, anton wrote:
> > > I think we need to add section to README describing on how to use
artifacts
> > from
> > > bintray for Gradle (and may be maven).
> > 
> > Acknowledged.
> 
> Any update?

So I resumed working on that in the last week, but an issue was found while
testing it with Jens. The adblock-android artifact is not being generated due to
a problem that relates to the fact that it has native libraries. Once I finish
some pending tasks, I'll move back to it to figure out how to fix that

[anton, 2018-07-03 09:51:04]

On 2018/07/03 09:22:06, diegocarloslima wrote:
> On 2018/07/02 10:06:32, anton wrote:
> > On 2018/06/04 20:41:20, diegocarloslima wrote:
> > >
> >
>
https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
> > > File adblock-android/build.gradle (right):
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/bui...
> > > adblock-android/build.gradle:72: }
> > > On 2018/05/21 19:50:51, anton wrote:
> > > > I think we need to add section to README describing on how to use
> artifacts
> > > from
> > > > bintray for Gradle (and may be maven).
> > > 
> > > Acknowledged.
> > 
> > Any update?
> 
> So I resumed working on that in the last week, but an issue was found while
> testing it with Jens. The adblock-android artifact is not being generated due
to
> a problem that relates to the fact that it has native libraries. Once I finish
> some pending tasks, I'll move back to it to figure out how to fix that

Sure, take into account now it's a bit more complicated:
https://hg.adblockplus.org/libadblockplus-android/rev/83a9ac3a66fe

[diegocarloslima, 2018-07-09 16:01:01]

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
File
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java
(right):

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java:87:
* @param urlToResourceIdMap map URL android resource id for preloaded
subscriptions
Needed to remove the `->` due to an error while running the Javadoc task

[anton, 2018-07-10 09:51:39]

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
File adblock-android/AndroidManifest.xml (right):

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
adblock-android/AndroidManifest.xml:9: <uses-permission
android:name="android.permission.ACCESS_NETWORK_STATE"/>
Unrelated change.

It's mentioned in README that end-user app should add according permissions.
If we want to simplify end-user app developers life then we should add the 2nd
permission too.
Previously it was not merged i believe (permissions from lib aars to apk).

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
File
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java
(right):

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java:87:
* @param urlToResourceIdMap map URL android resource id for preloaded
subscriptions
On 2018/07/09 16:01:01, diegocarloslima wrote:
> Needed to remove the `->` due to an error while running the Javadoc task

map URL _to_ android resource id ...
This looks like unrelated change

[jens, 2018-07-10 10:08:10]

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
File adblock-android/AndroidManifest.xml (right):

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
adblock-android/AndroidManifest.xml:9: <uses-permission
android:name="android.permission.ACCESS_NETWORK_STATE"/>
I always prefer to not add permissions in the library, but to add them myself in
the app project.

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
File
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java
(right):

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java:87:
* @param urlToResourceIdMap map URL android resource id for preloaded
subscriptions
the word "to" is missing.

[diegocarloslima, 2018-07-10 12:26:03]

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
File adblock-android/AndroidManifest.xml (right):

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
adblock-android/AndroidManifest.xml:9: <uses-permission
android:name="android.permission.ACCESS_NETWORK_STATE"/>
On 2018/07/10 10:08:10, jens wrote:
> I always prefer to not add permissions in the library, but to add them myself
in
> the app project.

As explained through IRC, this change is not unrelated, since the bintrayUpload
task runs the lint task, which throws an error due to this missing permission. I
will also add the other permission, to make it consistent

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
File
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java
(right):

https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java:87:
* @param urlToResourceIdMap map URL android resource id for preloaded
subscriptions
On 2018/07/10 10:08:10, jens wrote:
> the word "to" is missing.

I will add the `to` word

[anton, 2018-07-10 13:34:01]

On 2018/07/10 12:26:03, diegocarloslima wrote:
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
> File adblock-android/AndroidManifest.xml (right):
> 
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
> adblock-android/AndroidManifest.xml:9: <uses-permission
> android:name="android.permission.ACCESS_NETWORK_STATE"/>
> On 2018/07/10 10:08:10, jens wrote:
> > I always prefer to not add permissions in the library, but to add them
myself
> in
> > the app project.
> 
> As explained through IRC, this change is not unrelated, since the
bintrayUpload
> task runs the lint task, which throws an error due to this missing permission.
I
> will also add the other permission, to make it consistent
> 
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
> File
>
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java
> (right):
> 
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
>
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java:87:
> * @param urlToResourceIdMap map URL android resource id for preloaded
> subscriptions
> On 2018/07/10 10:08:10, jens wrote:
> > the word "to" is missing.
> 
> I will add the `to` word

LGTM

[jens, 2018-07-10 13:47:58]

On 2018/07/10 13:34:01, anton wrote:
> On 2018/07/10 12:26:03, diegocarloslima wrote:
> >
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
> > File adblock-android/AndroidManifest.xml (right):
> > 
> >
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
> > adblock-android/AndroidManifest.xml:9: <uses-permission
> > android:name="android.permission.ACCESS_NETWORK_STATE"/>
> > On 2018/07/10 10:08:10, jens wrote:
> > > I always prefer to not add permissions in the library, but to add them
> myself
> > in
> > > the app project.
> > 
> > As explained through IRC, this change is not unrelated, since the
> bintrayUpload
> > task runs the lint task, which throws an error due to this missing
permission.
> I
> > will also add the other permission, to make it consistent
> > 
> >
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
> > File
> >
>
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
> >
>
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java:87:
> > * @param urlToResourceIdMap map URL android resource id for preloaded
> > subscriptions
> > On 2018/07/10 10:08:10, jens wrote:
> > > the word "to" is missing.
> > 
> > I will add the `to` word
> 
> LGTM

LGTM