Fixes #68 - Add email spam protection for privacy email address on /privacy

Fixes #68 - Add email spam protection for privacy email address on /privacy

[juliandoucette, 2018-05-22 13:35:09]

LGTM

This was meant to be done after the next privacy policy update (ongoing). But I
guess it can be done before too as long as I remember to use it while
implementing said update.

https://codereview.adblockplus.org/29785584/diff/29785585/pages/privacy.md
File pages/privacy.md (right):

https://codereview.adblockplus.org/29785584/diff/29785585/pages/privacy.md#ne...
pages/privacy.md:149: {{ your-rights-long-paragraph Naturally you have the right
to receive, upon request, information about the personal data stored by us about
you. You also have the right to correct inaccurate personal data and to block
and delete details. To do so, please contact us via
[<fix>privacy@eyeo.com</fix>](#){:
data-address="bWFpbHRvOnByaXZhY3lAZXllby5jb20=" } or write to the above address.
}}
A little pointless in this case :P

[ire, 2018-05-22 16:36:27]

On 2018/05/22 13:35:09, juliandoucette wrote:
> This was meant to be done after the next privacy policy update (ongoing). But
I
> guess it can be done before too as long as I remember to use it while
> implementing said update.

Oh okay, didn't see any mention of this in the issue. We can hold it back then?
Since my comment about the inline email will delay it anyway?

https://codereview.adblockplus.org/29785584/diff/29785585/pages/privacy.md
File pages/privacy.md (right):

https://codereview.adblockplus.org/29785584/diff/29785585/pages/privacy.md#ne...
pages/privacy.md:149: {{ your-rights-long-paragraph Naturally you have the right
to receive, upon request, information about the personal data stored by us about
you. You also have the right to correct inaccurate personal data and to block
and delete details. To do so, please contact us via
[<fix>privacy@eyeo.com</fix>](#){:
data-address="bWFpbHRvOnByaXZhY3lAZXllby5jb20=" } or write to the above address.
}}
On 2018/05/22 13:35:09, juliandoucette wrote:
> A little pointless in this case :P

See https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/68#note_73935746
. 

There doesn't seem to be a point in doing this at all if we don't do it
everywhere (including this text)

[ire, 2018-05-23 15:41:14]

New patch set up with masking for the link text

[ire, 2018-05-23 16:25:38]

https://codereview.adblockplus.org/29785584/diff/29788565/static/js/address-m...
File static/js/address-masking.js (right):

https://codereview.adblockplus.org/29785584/diff/29788565/static/js/address-m...
static/js/address-masking.js:25: if (target.hasAttribute("data-replace-text"))
Note: If you agree with this implementation we can add it to website-defaults

[juliandoucette, 2018-05-24 16:12:37]

LGTM + NIT

If we're going to replace more than one tag property then I'd prefer to group
them using a data object instead of individual data attributes. e.g. <a
data-replace="{href: ..., textContent: ...}"

What do you think?

[juliandoucette, 2018-05-24 16:13:10]

(or data-mask* instead of data-replace.)

[juliandoucette, 2018-05-24 17:11:39]

See https://gitlab.com/eyeo/websites/website-defaults/issues/6

[ire, 2018-05-25 07:16:54]

On 2018/05/24 17:11:39, juliandoucette wrote:
> See https://gitlab.com/eyeo/websites/website-defaults/issues/6

Seen. I think we should implement that change before moving ahead with this.

[ire, 2018-05-25 09:30:28]

New patch set up

[juliandoucette, 2018-05-25 09:38:27]

LGTM