Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29789555: Noissue - Discard regular expression source when no longer needed (Closed)

Created:
May 24, 2018, 6:26 a.m. by Manish Jethani
Modified:
May 25, 2018, 1:08 p.m.
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Discard regular expression source when no longer needed

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete property after adding alternative #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M lib/filterClasses.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
May 24, 2018, 6:26 a.m. (2018-05-24 06:26:36 UTC) #1
Manish Jethani
Patch Set 1 For both sitekeysSource and domainsSource, we discard the values once consumed. We ...
May 24, 2018, 6:28 a.m. (2018-05-24 06:28:33 UTC) #2
kzar
https://codereview.adblockplus.org/29789555/diff/29789556/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29789555/diff/29789556/lib/filterClasses.js#newcode671 lib/filterClasses.js:671: delete this.regexpSource; Nit: I'd prefer we did this after ...
May 24, 2018, 1:43 p.m. (2018-05-24 13:43:24 UTC) #3
Manish Jethani
Patch Set 2: Delete property after adding alternative https://codereview.adblockplus.org/29789555/diff/29789556/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29789555/diff/29789556/lib/filterClasses.js#newcode671 lib/filterClasses.js:671: delete ...
May 25, 2018, 3:43 a.m. (2018-05-25 03:43:36 UTC) #4
kzar
May 25, 2018, 12:20 p.m. (2018-05-25 12:20:22 UTC) #5
Thanks, LGTM!

Powered by Google App Engine
This is Rietveld