Unified Diff: lib/filterClasses.js
Issue 29789555:
Noissue - Discard regular expression source when no longer needed (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set:
Created May 24, 2018, 6:26 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/filterClasses.js |
| =================================================================== |
| --- a/lib/filterClasses.js |
| +++ b/lib/filterClasses.js |
| @@ -663,16 +663,17 @@ |
| // Despite this property being cached, the getter is called |
| // several times on Safari, due to WebKit bug 132872 |
| let prop = Object.getOwnPropertyDescriptor(this, "regexp"); |
| if (prop) |
| return prop.value; |
| let source = Filter.toRegExp(this.regexpSource); |
| let regexp = new RegExp(source, this.matchCase ? "" : "i"); |
| + delete this.regexpSource; |
|
kzar
2018/05/24 13:43:24
Nit: I'd prefer we did this after the defineProper
Manish Jethani
2018/05/25 03:43:36
Yup, me too.
|
| Object.defineProperty(this, "regexp", {value: regexp}); |
| return regexp; |
| }, |
| /** |
| * Content types the filter applies to, combination of values from |
| * RegExpFilter.typeMap |
| * @type {number} |
| */ |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
