Issue 29790573: Fixes #6 - Extend address masking to mask other attributes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29790573: Fixes #6 - Extend address masking to mask other attributes (Closed)

Created:
May 25, 2018, 7:34 a.m. by ire

Modified:
May 25, 2018, 9:02 a.m.

Reviewers:
juliandoucette

Base URL:
https://hg.adblockplus.org/website-defaults

Visibility:
Public.

Description

Fixes #6 - Extend address masking to mask other attributes

Patch Set 2 : Addressed NITs #

Created: May 25, 2018, 9:01 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
	M	pages/address-masking.md	View	1	1 chunk	+14 lines, -4 lines	0 comments	Download
	M	static/js/address-masking.js	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ire

Ready for review https://codereview.adblockplus.org/29790573/diff/29790574/pages/address-masking.md File pages/address-masking.md (right): https://codereview.adblockplus.org/29790573/diff/29790574/pages/address-masking.md#newcode25 pages/address-masking.md:25: [Private Email](#){: data-mask='{ "href": "bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t" }' ...

May 25, 2018, 7:35 a.m. (2018-05-25 07:35:05 UTC) #2

juliandoucette

LGTM + NITs https://codereview.adblockplus.org/29790573/diff/29790574/pages/address-masking.md File pages/address-masking.md (right): https://codereview.adblockplus.org/29790573/diff/29790574/pages/address-masking.md#newcode25 pages/address-masking.md:25: [Private Email](#){: data-mask='{ "href": "bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t" }' ...

May 25, 2018, 8:51 a.m. (2018-05-25 08:51:00 UTC) #3

ire

May 25, 2018, 9:02 a.m. (2018-05-25 09:02:10 UTC) #4

Thanks. I've made the changes, will commit & push now

https://codereview.adblockplus.org/29790573/diff/29790574/pages/address-maski...
File pages/address-masking.md (right):

https://codereview.adblockplus.org/29790573/diff/29790574/pages/address-maski...
pages/address-masking.md:25: [Private Email](#){: data-mask='{ "href":
"bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t" }'
On 2018/05/25 08:50:59, juliandoucette wrote:
> On 2018/05/25 07:35:05, ire wrote:
> > This requires that we use a single quote for the opening closing of the
> > data-mask attribute
> 
> You mean we can't just escape or flip the quotes the other way (double outer,
> single inner)?
> 
> If so, it's worth mentioning that on the page.

No we can't. I will add that.

https://codereview.adblockplus.org/29790573/diff/29790574/pages/address-maski...
pages/address-masking.md:27: [#](#){: data-mask='{ "href":
"bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t", "textContent":
"dXNlcm5hbWVAZXhhbXBsZS5jb20=" }'
On 2018/05/25 08:50:59, juliandoucette wrote:
> TOL: Seems like we could make this friendlier than "#"?

Changed to "email"

Expand All Messages | Collapse All Messages