Issue 29790621: Noissue - Delete properties instead of setting to null

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29790621: Noissue - Delete properties instead of setting to null (Closed)

Created:
May 25, 2018, 1:48 p.m. by Manish Jethani

Modified:
May 25, 2018, 10:22 p.m.

Reviewers:
kzar

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Noissue - Delete properties instead of setting to null

Patch Set 1 #

Created: May 25, 2018, 1:48 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	lib/filterClasses.js	View		2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Manish Jethani

Patch Set 1 What we did in https://hg.adblockplus.org/adblockpluscore/rev/9194ac6bd473

May 25, 2018, 1:49 p.m. (2018-05-25 13:49:11 UTC) #2

kzar

NOT LGTM, this change seems pointless and if you're trying to make the code more ...

May 25, 2018, 1:58 p.m. (2018-05-25 13:58:50 UTC) #3

Manish Jethani

May 25, 2018, 10:21 p.m. (2018-05-25 22:21:49 UTC) #4

On 2018/05/25 13:58:50, kzar wrote:
> NOT LGTM, this change seems pointless and if you're trying to make the code
more
> consistent you'd be better off adjusting your previous change to just assign
> null instead.

Well it wasn't supposed to be pointless, I thought deleting the property would
improve performance and memory usage. It turns out I couldn't be more wrong. I
did some tests and it seems the opposite is true.

Here's the alternative change then:

https://codereview.adblockplus.org/29790626

Expand All Messages | Collapse All Messages