Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 29790629: Issue 6690 - Always ignore trailing dot in document domain (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by Manish Jethani
Modified:
1 year, 3 months ago
Reviewers:
kzar, Sebastian Noack
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Ignore trailing dot in ElemHide.getSelectorsForDomain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -30 lines) Patch
M lib/elemHide.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/filterClasses.js View 5 chunks +2 lines, -22 lines 0 comments Download
M test/domainRestrictions.js View 4 chunks +7 lines, -7 lines 0 comments Download
M test/elemHide.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
Manish Jethani
1 year, 3 months ago (2018-05-25 23:51:58 UTC) #1
Manish Jethani
Patch Set 1 Based on our discussion in the Trac issue.
1 year, 3 months ago (2018-05-25 23:53:56 UTC) #2
Manish Jethani
Patch Set 2: Ignore trailing dot in ElemHide.getSelectorsForDomain Since we have our own logic here ...
1 year, 3 months ago (2018-05-26 00:10:39 UTC) #3
Sebastian Noack
LGTM. But mind that we also have to do a couple changes to adblockpluschrome in ...
1 year, 3 months ago (2018-05-29 11:52:32 UTC) #4
Manish Jethani
On 2018/05/29 11:52:32, Sebastian Noack wrote: > LGTM. Thanks! Dave, would you have time to ...
1 year, 3 months ago (2018-06-04 10:17:45 UTC) #5
kzar
On 2018/06/04 10:17:45, Manish Jethani wrote: > On 2018/05/29 11:52:32, Sebastian Noack wrote: > > ...
1 year, 3 months ago (2018-06-04 17:52:33 UTC) #6
Manish Jethani
1 year, 3 months ago (2018-06-05 04:50:08 UTC) #7
On 2018/06/04 17:52:33, kzar wrote:
> On 2018/06/04 10:17:45, Manish Jethani wrote:
> > On 2018/05/29 11:52:32, Sebastian Noack wrote:
> > > LGTM.
> > 
> > Thanks!
> > 
> > Dave, would you have time to take a look at this one?
> 
> Sorry for delaying this! I have a backlog of emails and reviews which I'm
> working through, so if you'd like to go ahead without my review feel free.
> Otherwise I'll try and have a look soon.

Sounds good, thanks! I've committed it now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5