Issue 29790629: Issue 6690 - Always ignore trailing dot in document domain

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29790629: Issue 6690 - Always ignore trailing dot in document domain (Closed)

Created:
May 25, 2018, 11:51 p.m. by Manish Jethani

Modified:
June 5, 2018, 4:50 a.m.

Reviewers:
Sebastian Noack, kzar

CC:
sergei

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Ignore trailing dot in ElemHide.getSelectorsForDomain #

Created: May 26, 2018, 12:10 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -30 lines)			Patch
M	lib/elemHide.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/filterClasses.js	View		5 chunks	+2 lines, -22 lines	0 comments	Download
M	test/domainRestrictions.js	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	test/elemHide.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Manish Jethani

Patch Set 1 Based on our discussion in the Trac issue.

May 25, 2018, 11:53 p.m. (2018-05-25 23:53:56 UTC) #2

Manish Jethani

Patch Set 2: Ignore trailing dot in ElemHide.getSelectorsForDomain Since we have our own logic here ...

May 26, 2018, 12:10 a.m. (2018-05-26 00:10:39 UTC) #3

Sebastian Noack

LGTM. But mind that we also have to do a couple changes to adblockpluschrome in ...

May 29, 2018, 11:52 a.m. (2018-05-29 11:52:32 UTC) #4

Manish Jethani

On 2018/05/29 11:52:32, Sebastian Noack wrote: > LGTM. Thanks! Dave, would you have time to ...

June 4, 2018, 10:17 a.m. (2018-06-04 10:17:45 UTC) #5

kzar

On 2018/06/04 10:17:45, Manish Jethani wrote: > On 2018/05/29 11:52:32, Sebastian Noack wrote: > > ...

June 4, 2018, 5:52 p.m. (2018-06-04 17:52:33 UTC) #6

Manish Jethani

June 5, 2018, 4:50 a.m. (2018-06-05 04:50:08 UTC) #7

On 2018/06/04 17:52:33, kzar wrote:
> On 2018/06/04 10:17:45, Manish Jethani wrote:
> > On 2018/05/29 11:52:32, Sebastian Noack wrote:
> > > LGTM.
> > 
> > Thanks!
> > 
> > Dave, would you have time to take a look at this one?
> 
> Sorry for delaying this! I have a backlog of emails and reviews which I'm
> working through, so if you'd like to go ahead without my review feel free.
> Otherwise I'll try and have a look soon.

Sounds good, thanks! I've committed it now.

Expand All Messages | Collapse All Messages