Issue 6690 - Always ignore trailing dot in document domain

test/domainRestrictions.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 52 matching lines @@
 
   test.done();
 };
 
 exports.testDomainRestrictedBlockingFilters = function(test)
 {
   testActive(test, "foo$domain=example.com", null, false, false);
   testActive(test, "foo$domain=example.com", "com", false, true);
   testActive(test, "foo$domain=example.com", "example.com", true, true);
   testActive(test, "foo$domain=example.com", "example.com.", true, true);
-  testActive(test, "foo$domain=example.com.", "example.com", true, true);
-  testActive(test, "foo$domain=example.com.", "example.com.", true, true);
+  testActive(test, "foo$domain=example.com.", "example.com", false, false);
+  testActive(test, "foo$domain=example.com.", "example.com.", false, false);
   testActive(test, "foo$domain=example.com", "foo.example.com", true, false);
   testActive(test, "foo$domain=example.com", "mple.com", false, false);
 
   test.done();
 };
 
 exports.testDomainRestrictedHidingRules = function(test)
 {
   testActive(test, "example.com##foo", null, false, false);
   testActive(test, "example.com##foo", "com", false, true);
   testActive(test, "example.com##foo", "example.com", true, true);
-  testActive(test, "example.com##foo", "example.com.", false, false);
+  testActive(test, "example.com##foo", "example.com.", true, true);
   testActive(test, "example.com.##foo", "example.com", false, false);
-  testActive(test, "example.com.##foo", "example.com.", true, true);
+  testActive(test, "example.com.##foo", "example.com.", false, false);
   testActive(test, "example.com##foo", "foo.example.com", true, false);
   testActive(test, "example.com##foo", "mple.com", false, false);
 
   test.done();
 };
 
 exports.testBlockingFiltersRestrictedToDomainAndItsSubdomain = function(test)
 {
   testActive(test, "foo$domain=example.com|foo.example.com", null, false, false);
   testActive(test, "foo$domain=example.com|foo.example.com", "com", false, true);
   testActive(test, "foo$domain=example.com|foo.example.com", "example.com", true, true);
   testActive(test, "foo$domain=example.com|foo.example.com", "example.com.", true, true);
   testActive(test, "foo$domain=example.com|foo.example.com", "foo.example.com", true, false);
   testActive(test, "foo$domain=example.com|foo.example.com", "mple.com", false, false);
 
   test.done();
 };
 
 exports.testHidingRulesRestrictedToDomainAndItsSubdomain = function(test)
 {
   testActive(test, "example.com,foo.example.com##foo", null, false, false);
   testActive(test, "example.com,foo.example.com##foo", "com", false, true);
   testActive(test, "example.com,foo.example.com##foo", "example.com", true, true);
-  testActive(test, "example.com,foo.example.com##foo", "example.com.", false, false);
+  testActive(test, "example.com,foo.example.com##foo", "example.com.", true, true);
   testActive(test, "example.com,foo.example.com##foo", "foo.example.com", true, false);
   testActive(test, "example.com,foo.example.com##foo", "mple.com", false, false);
 
   test.done();
 };
 
 exports.testBlockingFiltersWithExceptionForASubdomain = function(test)
 {
   testActive(test, "foo$domain=~foo.example.com", null, true, false);
   testActive(test, "foo$domain=~foo.example.com", "com", true, false);
@@ skipping 27 matching lines @@
   testActive(test, "foo$domain=example.com|~foo.example.com", "mple.com", false, false);
 
   test.done();
 };
 
 exports.testHidingRulesForDomainButNotItsSubdomain = function(test)
 {
   testActive(test, "example.com,~foo.example.com##foo", null, false, false);
   testActive(test, "example.com,~foo.example.com##foo", "com", false, true);
   testActive(test, "example.com,~foo.example.com##foo", "example.com", true, true);
-  testActive(test, "example.com,~foo.example.com##foo", "example.com.", false, false);
+  testActive(test, "example.com,~foo.example.com##foo", "example.com.", true, true);
   testActive(test, "example.com,~foo.example.com##foo", "foo.example.com", false, false);
   testActive(test, "example.com,~foo.example.com##foo", "mple.com", false, false);
 
   test.done();
 };
 
 exports.testBlockingFiltersForDomainButNotItsTLD = function(test)
 {
   testActive(test, "foo$domain=example.com|~com", null, false, false);
   testActive(test, "foo$domain=example.com|~com", "com", false, true);
   testActive(test, "foo$domain=example.com|~com", "example.com", true, true);
   testActive(test, "foo$domain=example.com|~com", "example.com.", true, true);
   testActive(test, "foo$domain=example.com|~com", "foo.example.com", true, false);
   testActive(test, "foo$domain=example.com|~com", "mple.com", false, false);
 
   test.done();
 };
 
 exports.testHidingRulesForDomainButNotItsTLD = function(test)
 {
   testActive(test, "example.com,~com##foo", null, false, false);
   testActive(test, "example.com,~com##foo", "com", false, true);
   testActive(test, "example.com,~com##foo", "example.com", true, true);
-  testActive(test, "example.com,~com##foo", "example.com.", false, false);
+  testActive(test, "example.com,~com##foo", "example.com.", true, true);
   testActive(test, "example.com,~com##foo", "foo.example.com", true, false);
   testActive(test, "example.com,~com##foo", "mple.com", false, false);
 
   test.done();
 };
 
 exports.testBlockingFiltersRestrictedToAnUnrelatedDomain = function(test)
 {
   testActive(test, "foo$domain=nnnnnnn.nnn", null, false, false);
   testActive(test, "foo$domain=nnnnnnn.nnn", "com", false, false);
   testActive(test, "foo$domain=nnnnnnn.nnn", "example.com", false, false);
   testActive(test, "foo$domain=nnnnnnn.nnn", "example.com.", false, false);
   testActive(test, "foo$domain=nnnnnnn.nnn", "foo.example.com", false, false);
   testActive(test, "foo$domain=nnnnnnn.nnn", "mple.com", false, false);
 
   test.done();
 };
 
 exports.testHidingRulesRestrictedToAnUnrelatedDomain = function(test)
 {
   testActive(test, "nnnnnnn.nnn##foo", null, false, false);
   testActive(test, "nnnnnnn.nnn##foo", "com", false, false);
   testActive(test, "nnnnnnn.nnn##foo", "example.com", false, false);
   testActive(test, "nnnnnnn.nnn##foo", "example.com.", false, false);
   testActive(test, "nnnnnnn.nnn##foo", "foo.example.com", false, false);
   testActive(test, "nnnnnnn.nnn##foo", "mple.com", false, false);
 
   test.done();
 };