Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29790638: Noissue - Add criteria test for ~example.com##world (Closed)

Created:
May 26, 2018, 12:24 a.m. by Manish Jethani
Modified:
June 7, 2018, 2:10 p.m.
Reviewers:
sergei, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/elemHide.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
May 26, 2018, 12:25 a.m. (2018-05-26 00:25:00 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29790638/diff/29790639/test/elemHide.js File test/elemHide.js (right): https://codereview.adblockplus.org/29790638/diff/29790639/test/elemHide.js#newcode182 test/elemHide.js:182: testResult(test, "example.com", [], true); Surely the ...
May 26, 2018, 12:26 a.m. (2018-05-26 00:26:33 UTC) #2
Manish Jethani
Patch Set 2: Rebase Sergei, mind taking a quick look? It's a trivial change, just ...
June 5, 2018, 5:39 a.m. (2018-06-05 05:39:28 UTC) #3
kzar
June 7, 2018, 1:41 p.m. (2018-06-07 13:41:59 UTC) #4
Well spotted, LGTM.

Powered by Google App Engine
This is Rietveld