Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29793587: #11421 - Redirect broken links on adblockbrowser.org (Closed)

Created:
May 29, 2018, 10:31 p.m. by f.lopez
Modified:
May 30, 2018, 9:50 p.m.
Reviewers:
mathias, Fred
Visibility:
Public.

Description

#11421 - Redirect broken links on adblockbrowser.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : For comment 3 + removing duplicated entries #

Total comments: 1

Patch Set 3 : For comment 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M hiera/roles/web/adblockbrowser.yaml View 1 2 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7
f.lopez
May 29, 2018, 10:31 p.m. (2018-05-29 22:31:07 UTC) #1
mathias
https://codereview.adblockplus.org/29793587/diff/29793588/hiera/roles/web/adblockbrowser.yaml File hiera/roles/web/adblockbrowser.yaml (right): https://codereview.adblockplus.org/29793587/diff/29793588/hiera/roles/web/adblockbrowser.yaml#newcode45 hiera/roles/web/adblockbrowser.yaml:45: location /forum/viewforum { Can't we just re-write all /forum/viewforum ...
May 30, 2018, 7:45 a.m. (2018-05-30 07:45:29 UTC) #2
f.lopez
https://codereview.adblockplus.org/29793587/diff/29793588/hiera/roles/web/adblockbrowser.yaml File hiera/roles/web/adblockbrowser.yaml (right): https://codereview.adblockplus.org/29793587/diff/29793588/hiera/roles/web/adblockbrowser.yaml#newcode45 hiera/roles/web/adblockbrowser.yaml:45: location /forum/viewforum { On 2018/05/30 07:45:28, mathias wrote: > ...
May 30, 2018, 7:03 p.m. (2018-05-30 19:03:41 UTC) #3
f.lopez
May 30, 2018, 7:15 p.m. (2018-05-30 19:15:11 UTC) #4
mathias
https://codereview.adblockplus.org/29793587/diff/29794583/hiera/roles/web/adblockbrowser.yaml File hiera/roles/web/adblockbrowser.yaml (right): https://codereview.adblockplus.org/29793587/diff/29794583/hiera/roles/web/adblockbrowser.yaml#newcode44 hiera/roles/web/adblockbrowser.yaml:44: rewrite ^(.*)/(forum)/(view(forum|topic)) https://adblockplus.org/$2/$3.php permanent; Please improve on that regular ...
May 30, 2018, 9:15 p.m. (2018-05-30 21:15:40 UTC) #5
f.lopez
May 30, 2018, 9:43 p.m. (2018-05-30 21:43:13 UTC) #6
mathias
May 30, 2018, 9:45 p.m. (2018-05-30 21:45:33 UTC) #7
LGTM.

Powered by Google App Engine
This is Rietveld