Issue 29794577: Issue 6708 - Update adblockplusui dependencies to f6cbede1b008

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29794577: Issue 6708 - Update adblockplusui dependencies to f6cbede1b008 (Closed)

Created:
May 30, 2018, 3:22 p.m. by saroyanm

Modified:
May 30, 2018, 4:09 p.m.

Reviewers:
Sebastian Noack, kzar

CC:
wspee

Visibility:
Public.

Description

Issue 6708 - Update adblockplusui dependencies to f6cbede1b008

Patch Set 1 #

Created: May 30, 2018, 3:22 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	dependencies	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kzar

LGTM assuming that none of the included changes require further changes here and that you've ...

May 30, 2018, 3:51 p.m. (2018-05-30 15:51:00 UTC) #2

saroyanm

On 2018/05/30 15:51:00, kzar wrote: > LGTM assuming that none of the included changes require ...

May 30, 2018, 3:56 p.m. (2018-05-30 15:56:07 UTC) #3

kzar

May 30, 2018, 3:58 p.m. (2018-05-30 15:58:23 UTC) #4

On 2018/05/30 15:56:07, saroyanm wrote:
> Yes I did some smoke test and yes, none of the changes require further
changes,
> I think we are good to proceed into Q/A Phase and start the release.

Awesome, thanks.

Expand All Messages | Collapse All Messages