Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29796565: Fixes #1 - Implement external link icon (Closed)

Created:
June 1, 2018, 2:03 p.m. by ire
Modified:
June 8, 2018, 6:04 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Fixes #1 - Implement external link icon

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M pages/images.md View 2 chunks +32 lines, -0 lines 0 comments Download
A static/img/png/external-icon-black.png View Binary file 0 comments Download
A static/img/png/external-icon-white.png View Binary file 0 comments Download
A static/img/svg/external-icon-black.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/img/svg/external-icon-white.svg View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
ire
June 1, 2018, 2:03 p.m. (2018-06-01 14:03:15 UTC) #1
juliandoucette
I think you have the right idea here - but why no CSS? We could ...
June 5, 2018, 12:59 p.m. (2018-06-05 12:59:40 UTC) #2
ire
On 2018/06/05 12:59:40, juliandoucette wrote: > I think you have the right idea here - ...
June 6, 2018, 2:35 p.m. (2018-06-06 14:35:01 UTC) #3
juliandoucette
LGTM I think we can provide some sensible defaults separately. This is a good start.
June 8, 2018, 5:08 p.m. (2018-06-08 17:08:07 UTC) #4
ire
June 8, 2018, 6:04 p.m. (2018-06-08 18:04:16 UTC) #5
On 2018/06/08 17:08:07, juliandoucette wrote:
> LGTM
> 
> I think we can provide some sensible defaults separately. This is a good
start.

Ack

Powered by Google App Engine
This is Rietveld