metadata.chrome - Issue 29796577: Issue 6720 - Do not package the qunit test files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: metadata.chrome

Issue 29796577: Issue 6720 - Do not package the qunit test files. (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Patch Set: Created June 1, 2018, 6:03 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [general]	1 [general]

2 basename = adblockpluschrome	2 basename = adblockpluschrome

3 version = 3.1	3 version = 3.1

4 author = eyeo GmbH	4 author = eyeo GmbH

5 backgroundScripts = polyfill.js	5 backgroundScripts = polyfill.js

6 ext/common.js	6 ext/common.js

7 ext/background.js	7 ext/background.js

8 lib/compat.js	8 lib/compat.js

9 lib/publicSuffixList.js	9 lib/publicSuffixList.js

10 lib/adblockplus.js	10 lib/adblockplus.js

(...skipping 138 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
149 lib/uninstall.js	149 lib/uninstall.js

150 lib/csp.js	150 lib/csp.js

151 lib/cssInjection.js	151 lib/cssInjection.js

152 adblockplusui/messageResponder.js	152 adblockplusui/messageResponder.js

153 include.preload.js =	153 include.preload.js =

154 include.preload.js	154 include.preload.js

155 inject.preload.js	155 inject.preload.js

156 include.postload.js =	156 include.postload.js =

157 subscriptionLink.postload.js	157 subscriptionLink.postload.js

158 composer.postload.js	158 composer.postload.js

159 qunit/tests.js =
tlucas 2018/06/04 09:52:27 This would fix the ticket, but it would also break This would fix the ticket, but it would also break unit-testing in the devenv builds. FWIW i think the issue should be handled in `buildtools`, rather than in `adblockpluschrome` hub 2018/06/04 12:21:18 It actually fixes the unit testing in devenv, whic Show quoted text On 2018/06/04 09:52:27, tlucas wrote: > This would fix the ticket, but it would also break unit-testing in the devenv > builds. > > FWIW i think the issue should be handled in `buildtools`, rather than in > `adblockpluschrome` It actually fixes the unit testing in devenv, which is how I arrived here. packagerChrome.py line 209 it add the second qunit/tests.js bundle to the webpack configuration, generate it a second time. And from what I could see, the second one might be overwritten by the first one. Oh yeah because I was adding a test at that point, so that's how I noticed. The alternative would be to remove that block in packagerChrome, but then we'd ship the qunit tests in the release. (and we'd have to add new tests in the manifest - which is not a problem, just a change)
160 qunit/common.js

161 qunit/tests/prefs.js

162 qunit/tests/url.js

163 qunit/tests/cssEscaping.js

164	159

165 [import_locales]	160 [import_locales]

166 adblockplusui/locale//antiadblockInit.json =	161 adblockplusui/locale//antiadblockInit.json =

167 adblockplusui/locale//common.json =	162 adblockplusui/locale//common.json =

168 adblockplusui/locale//desktop-options.json =	163 adblockplusui/locale//desktop-options.json =

169 adblockplusui/locale//firstRun.json =	164 adblockplusui/locale//firstRun.json =

170 adblockplusui/locale//issue-reporter.json =	165 adblockplusui/locale//issue-reporter.json =

171 adblockplusui/locale//updates.json =	166 adblockplusui/locale//updates.json =

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »