Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29796577: Issue 6720 - Do not package the qunit test files. (Closed)

Created:
June 1, 2018, 6:03 p.m. by hub
Modified:
June 5, 2018, 3:45 a.m.
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6720 - Do not package the qunit test files.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M metadata.chrome View 1 chunk +0 lines, -5 lines 2 comments Download

Messages

Total messages: 4
hub
June 1, 2018, 6:03 p.m. (2018-06-01 18:03:43 UTC) #1
tlucas
Hey Hub, sorry for intruding this review, but i thought i might add something here ...
June 4, 2018, 9:52 a.m. (2018-06-04 09:52:28 UTC) #2
hub
https://codereview.adblockplus.org/29796577/diff/29796578/metadata.chrome File metadata.chrome (left): https://codereview.adblockplus.org/29796577/diff/29796578/metadata.chrome#oldcode159 metadata.chrome:159: qunit/tests.js = On 2018/06/04 09:52:27, tlucas wrote: > This ...
June 4, 2018, 12:21 p.m. (2018-06-04 12:21:19 UTC) #3
kzar
June 4, 2018, 5:45 p.m. (2018-06-04 17:45:17 UTC) #4
LGTM, but remember to push to the next branch.

Powered by Google App Engine
This is Rietveld