Issue 29796606: Issue 6722 - Fix Gradle build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29796606: Issue 6722 - Fix Gradle build (Closed)

Created:
June 1, 2018, 10:51 p.m. by diegocarloslima

Modified:
June 5, 2018, 8:33 p.m.

Reviewers:
anton, jens

Visibility:
Public.

Description

Issue 6722 - Fix Gradle build

Patch Set 1 #

Created: June 1, 2018, 10:51 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -1 line)			Patch
M	mobile/android/base/java/org/adblockplus/browser/AbpCheckBoxPreference.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/AdblockPlusApiCallback.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/AddOnBridge.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/BrowserAppUtils.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/InputValidatorDialogPreference.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/StartPane.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/SubscriptionContainer.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/SubscriptionPreferenceCategory.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/UrlUtils.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/java/org/adblockplus/browser/WhitelistedWebsitesPreferenceGroup.java	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	mobile/android/base/moz.build	View	1 chunk	+16 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

anton

On 2018/06/01 22:54:55, diegocarloslima wrote: i can't see any changes in java files, why are ...

June 4, 2018, 5:58 a.m. (2018-06-04 05:58:28 UTC) #2

diegocarloslima

On 2018/06/04 05:58:28, anton wrote: > On 2018/06/01 22:54:55, diegocarloslima wrote: > > i can't ...

June 4, 2018, 8:14 p.m. (2018-06-04 20:14:03 UTC) #3

anton

On 2018/06/04 20:14:03, diegocarloslima wrote: > On 2018/06/04 05:58:28, anton wrote: > > On 2018/06/01 ...

June 5, 2018, 6:50 a.m. (2018-06-05 06:50:27 UTC) #4

jens

June 5, 2018, 7:22 a.m. (2018-06-05 07:22:25 UTC) #5

On 2018/06/05 06:50:27, anton wrote:
> On 2018/06/04 20:14:03, diegocarloslima wrote:
> > On 2018/06/04 05:58:28, anton wrote:
> > > On 2018/06/01 22:54:55, diegocarloslima wrote:
> > > 
> > > i can't see any changes in java files, why are they marked as
"M"(odified)?
> > 
> > There were only changes in the 'moz.build' file. The others were moved from
> > 'mobile/android/thirdparty' to 'mobile/android/base/java'
> 
> LGTM then

LGTM

Expand All Messages | Collapse All Messages