Noissue - Avoid setting BlockingFilter instance properties

This saves ~800 KB on the heap.

[Manish Jethani, 2018-06-05 14:16:01]

Patch Set 1

We do this in the superclass RegExpFilter for the thirdParty and sitekeys
properties, we should do it in BlockingFilter for the collapse property as well,
at least for consistency. For what it's worth this saves ~200 KB on the heap.
Not much, but it's a good practice to avoid setting properties unnecessarily.

[Manish Jethani, 2018-06-05 14:23:17]

Patch Set 2: Avoid setting csp and rewrite properties as well

Now it saves ~900 KB for some reason. There's no need to set these properties
either.

[sergei, 2018-06-05 14:41:08]

On 2018/06/05 14:23:17, Manish Jethani wrote:
> Patch Set 2: Avoid setting csp and rewrite properties as well
> 
> Now it saves ~900 KB for some reason. There's no need to set these properties
> either.

Is it easy to compare the dumps of JS heaps somehow in order to see what makes
the difference? I would assume that it's because now the memory is not wasted
for the fields which are rarely used and the memory is indeed saved by sharing
the same "base-hidden" class.

[kzar, 2018-06-05 17:21:10]

Wow, LGTM.

[Manish Jethani, 2018-06-06 11:09:41]

On 2018/06/05 14:41:08, sergei wrote:
> On 2018/06/05 14:23:17, Manish Jethani wrote:
> > Patch Set 2: Avoid setting csp and rewrite properties as well
> > 
> > Now it saves ~900 KB for some reason. There's no need to set these
properties
> > either.
> 
> Is it easy to compare the dumps of JS heaps somehow in order to see what makes
> the difference? I would assume that it's because now the memory is not wasted
> for the fields which are rarely used and the memory is indeed saved by sharing
> the same "base-hidden" class.

I haven't checked, but it makes sense that the memory usage would go down
because of fewer properties [1]

[1]: https://v8project.blogspot.com/2017/08/fast-properties.html