Noissue - Avoid setting ActiveFilter.domainSource

Noissue - Avoid setting ActiveFilter.domainSource

[Manish Jethani, 2018-06-06 12:55:46]

Patch Set 1

Well this saves another ~1.5 MB. In the default subscriptions (EasyList+AA plus
warning removal list) out of ~80,000 filters only ~20,000 filters have domains.

[kzar, 2018-06-06 13:34:13]

Doesn't this change domainSource from an empty string to undefined? I wonder if
that matters.

[Manish Jethani, 2018-06-06 13:38:59]

On 2018/06/06 13:34:13, kzar wrote:
> Doesn't this change domainSource from an empty string to undefined? I wonder
if
> that matters.

For blocking filters domainSource is null. For hiding filters it's an empty
string. Either way the domains getter does a truthy check so empty string is
equivalent to null.

[kzar, 2018-06-06 13:58:54]

On 2018/06/06 13:38:59, Manish Jethani wrote:

> For blocking filters domainSource is null.

Shouldn't the doc string be `@param {?string} [domains]` then?

> Either way...

Ack, LGTM.

[Manish Jethani, 2018-06-06 14:08:22]

On 2018/06/06 13:58:54, kzar wrote:
> On 2018/06/06 13:38:59, Manish Jethani wrote:
> 
> > For blocking filters domainSource is null.
> 
> Shouldn't the doc string be `@param {?string} [domains]` then?

Brackets means "nullable" so it's correct.

> > Either way...
> 
> Ack, LGTM.

Thanks!

[Manish Jethani, 2018-06-09 10:35:20]

On 2018/06/06 14:08:22, Manish Jethani wrote:
> On 2018/06/06 13:58:54, kzar wrote:
> > On 2018/06/06 13:38:59, Manish Jethani wrote:
> > 
> > > For blocking filters domainSource is null.
> > 
> > Shouldn't the doc string be `@param {?string} [domains]` then?
> 
> Brackets means "nullable" so it's correct.

Sorry, I was wrong. It seems you're right, ? (nullable) and [] (optional) are
two different things. Anyway now let's do this as part of the other
documentation fixes, we need to make these kinds of changes in a lots of places.