Issue 29801555: Noissue - Check only first two characters for exception marker

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29801555: Noissue - Check only first two characters for exception marker (Closed)

Created:
June 7, 2018, 9:22 a.m. by Manish Jethani

Modified:
June 7, 2018, 2:09 p.m.

Reviewers:
sergei, kzar

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

In theory String.indexOf would search the entire string, whereas we are only interested in the first two characters here. I tried three approaches: String.startsWith, Stirng.substring(0, 2) == "@@", and the [] operator. The last one is the fastest. In practice this does not appear to make any significant difference in the performance of RegExpFilter.fromText, but maybe it's more visible on mobile and such.

Patch Set 1 #

Created: June 7, 2018, 9:22 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lib/filterClasses.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages