Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/common.js

Issue 29801558: Issue 6737 - Use String.includes instead of String.indexOf (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Replace more instances Created June 7, 2018, 9:51 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | lib/downloader.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 // remove leading wildcards 57 // remove leading wildcards
58 .replace(/^(\.\*)/, "") 58 .replace(/^(\.\*)/, "")
59 // remove trailing wildcards 59 // remove trailing wildcards
60 .replace(/(\.\*)$/, ""); 60 .replace(/(\.\*)$/, "");
61 } 61 }
62 62
63 exports.filterToRegExp = filterToRegExp; 63 exports.filterToRegExp = filterToRegExp;
64 64
65 function splitSelector(selector) 65 function splitSelector(selector)
66 { 66 {
67 if (selector.indexOf(",") == -1) 67 if (!selector.includes(","))
68 return [selector]; 68 return [selector];
69 69
70 let selectors = []; 70 let selectors = [];
71 let start = 0; 71 let start = 0;
72 let level = 0; 72 let level = 0;
73 let sep = ""; 73 let sep = "";
74 74
75 for (let i = 0; i < selector.length; i++) 75 for (let i = 0; i < selector.length; i++)
76 { 76 {
77 let chr = selector[i]; 77 let chr = selector[i];
(...skipping 16 matching lines...) Expand all
94 start = i + 1; 94 start = i + 1;
95 } 95 }
96 } 96 }
97 } 97 }
98 98
99 selectors.push(selector.substring(start)); 99 selectors.push(selector.substring(start));
100 return selectors; 100 return selectors;
101 } 101 }
102 102
103 exports.splitSelector = splitSelector; 103 exports.splitSelector = splitSelector;
OLDNEW
« no previous file with comments | « no previous file | lib/downloader.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld