Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29801558: Issue 6737 - Use String.includes instead of String.indexOf (Closed)

Created:
June 7, 2018, 9:27 a.m. by Manish Jethani
Modified:
June 7, 2018, 10:07 a.m.
Reviewers:
sergei, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Replace more instances #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/common.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/downloader.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/filterClasses.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Manish Jethani
June 7, 2018, 9:27 a.m. (2018-06-07 09:27:58 UTC) #1
Manish Jethani
Patch Set 1 Patch Set 2: Replace more instances Please see issue #6737 description.
June 7, 2018, 9:52 a.m. (2018-06-07 09:52:49 UTC) #2
Manish Jethani
By the way I could not find any such instances in the test directory.
June 7, 2018, 9:55 a.m. (2018-06-07 09:55:18 UTC) #3
kzar
June 7, 2018, 9:59 a.m. (2018-06-07 09:59:10 UTC) #4
Thanks for taking the time to do this, LGTM.

Powered by Google App Engine
This is Rietveld