Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 29801613: Issue 6321 - Move the popup under UI

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by a.giammarchi
Modified:
6 days, 21 hours ago
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : removed popup related translations #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : applied required changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -839 lines) Patch
M _locales/en_US/messages.json View 1 3 chunks +0 lines, -56 lines 0 comments Download
R icons/detailed/abp-64.png View 1 2 3 Binary file 0 comments Download
M metadata.chrome View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
R popup.html View 1 chunk +0 lines, -105 lines 0 comments Download
R popup.js View 1 chunk +0 lines, -341 lines 0 comments Download
R skin/popup.css View 1 chunk +0 lines, -337 lines 0 comments Download
R skin/popup.png View Binary file 0 comments Download

Messages

Total messages: 9
a.giammarchi
I have already tested this locally, after moving all files inside the adblockplusui folder (and ...
1 week, 3 days ago (2018-06-07 13:24:07 UTC) #1
Sebastian Noack
We probably should also move the translations used by the popup, as well as icons/detailed/abp-64.png, ...
1 week, 3 days ago (2018-06-07 15:21:27 UTC) #2
a.giammarchi
On 2018/06/07 15:21:27, Sebastian Noack wrote: > We probably should also move the translations used ...
1 week, 3 days ago (2018-06-07 15:33:27 UTC) #3
Sebastian Noack
On 2018/06/07 15:33:27, a.giammarchi wrote: > You mean to re-map all icons to adblockplusui/icons? > ...
1 week, 3 days ago (2018-06-07 16:17:58 UTC) #4
a.giammarchi
I have done all popup related updates and I don't think we need to dig ...
1 week, 2 days ago (2018-06-08 13:14:28 UTC) #5
Thomas Greiner
https://codereview.adblockplus.org/29801613/diff/29802559/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29801613/diff/29802559/metadata.chrome#newcode65 metadata.chrome:65: icons/detailed/abp-64.png = adblockplusui/skin/abp-64.png Detail: I don't see this file ...
1 week, 2 days ago (2018-06-08 13:33:23 UTC) #6
a.giammarchi
dropped file and useless overrides in the geko meta file. https://codereview.adblockplus.org/29801613/diff/29802559/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29801613/diff/29802559/metadata.chrome#newcode65 ...
1 week, 2 days ago (2018-06-08 13:44:23 UTC) #7
Thomas Greiner
LGTM Note that it's up to Sebastian to decide when and where this change should ...
6 days, 21 hours ago (2018-06-11 11:34:41 UTC) #8
a.giammarchi
6 days, 21 hours ago (2018-06-11 11:39:57 UTC) #9
On 2018/06/11 11:34:41, Thomas Greiner wrote:
> LGTM
> Note that it's up to Sebastian to decide when and where this change should
land.

Absolutely, and no rush at all


> In any case, we now know what we can/need to change in adblockplusui.

That was my intention: have a base to start developing as UI pull request.

Thanks
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5