Issue 6559 - Replace fromObject with fromMap

lib/filterStorage.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 57 matching lines @@
 
   /**
    * Will be set to true if no patterns.ini file exists.
    * @type {boolean}
    */
   firstRun: false,
 
   /**
    * Map of properties listed in the filter storage file before the sections
    * start. Right now this should be only the format version.
+   * @type {Map.<string,string>}
    */
-  fileProperties: Object.create(null),
+  fileProperties: new Map(),
 
   /**
    * List of filter subscriptions containing all filters
    * @type {Subscription[]}
    */
   subscriptions: [],
 
   /**
    * Map of subscriptions already on the list, by their URL/identifier
    * @type {Map.<string,Subscription>}
@@ skipping 592 matching lines @@
       filter.subscriptions.splice(i, 1);
   }
 }
 
 /**
  * Listener returned by FilterStorage.importData(), parses filter data.
  * @constructor
  */
 function INIParser()
 {
-  this.fileProperties = this.curObj = {};
+  this.fileProperties = this.curObj = new Map();
   this.subscriptions = [];
   this.knownFilters = new Map();
   this.knownSubscriptions = new Map();
 }
 INIParser.prototype =
 {
   linesProcessed: 0,
   subscriptions: null,
   knownFilters: null,
   knownSubscriptions: null,
   wantObj: true,
   fileProperties: null,
   curObj: null,
   curSection: null,
 
   process(val)
   {
     let origKnownFilters = Filter.knownFilters;
     Filter.knownFilters = this.knownFilters;
     let origKnownSubscriptions = Subscription.knownSubscriptions;
     Subscription.knownSubscriptions = this.knownSubscriptions;
     let match;
     try
     {
       if (this.wantObj === true && (match = /^(\w+)=(.*)$/.exec(val)))
-        this.curObj[match[1]] = match[2];
+        this.curObj.set(match[1], match[2]);
       else if (val === null || (match = /^\s*\[(.+)\]\s*$/.exec(val)))
       {
         if (this.curObj)
         {
           // Process current object before going to next section
           switch (this.curSection)
           {
             case "filter":
-              if ("text" in this.curObj)
-                Filter.fromObject(this.curObj);
+              if (this.curObj.has("text"))
+                Filter.fromMap(this.curObj);
               break;
             case "subscription": {
-              let subscription = Subscription.fromObject(this.curObj);
+              let subscription = Subscription.fromMap(this.curObj);
               if (subscription)
                 this.subscriptions.push(subscription);
               break;
             }
             case "subscription filters":
               if (this.subscriptions.length)
               {
                 let subscription = this.subscriptions[
                   this.subscriptions.length - 1
                 ];
@@ skipping 10 matching lines @@
 
         if (val === null)
           return;
 
         this.curSection = match[1].toLowerCase();
         switch (this.curSection)
         {
           case "filter":
           case "subscription":
             this.wantObj = true;
-            this.curObj = {};
+            this.curObj = new Map();
             break;
           case "subscription filters":
             this.wantObj = false;
             this.curObj = [];
             break;
           default:
             this.wantObj = undefined;
             this.curObj = null;
         }
       }
       else if (this.wantObj === false && val)
         this.curObj.push(val.replace(/\\\[/g, "["));
     }
     finally
     {
       Filter.knownFilters = origKnownFilters;
       Subscription.knownSubscriptions = origKnownSubscriptions;
     }
   }
 };