Issue 29802575: Issue 6559 - Replace fromObject with fromMap

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29802575: Issue 6559 - Replace fromObject with fromMap (Closed)

Created:
June 8, 2018, 1:59 p.m. by Manish Jethani

Modified:
March 18, 2019, 5:20 a.m.

Reviewers:
sergei, kzar

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Issue 6559 - Replace fromObject with fromMap

Patch Set 1 #

Created: June 8, 2018, 1:59 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -57 lines)			Patch
M	lib/filterClasses.js	View	1 chunk	+13 lines, -9 lines	0 comments	Download
M	lib/filterStorage.js	View	4 chunks	+8 lines, -7 lines	0 comments	Download
M	lib/subscriptionClasses.js	View	1 chunk	+53 lines, -33 lines	0 comments	Download
M	test/filterClasses.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/filterStorage_readwrite.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/subscriptionClasses.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Manish Jethani

June 8, 2018, 2:03 p.m. (2018-06-08 14:03:26 UTC) #2

Patch Set 1

My goal was to change the type of FilterStorage.fileProperties to Map, but I
went down the rabbit hole and ended up with this. In the end I'm not certain
that this is a great idea, but seems like populating and reading from a Map
rather than an Object (with dynamic property names) should make things faster.

Expand All Messages | Collapse All Messages