Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(391)

Issue 29802587: Issue 6559 - Change SpecialSubscription.defaultsMap to Map object (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Manish Jethani
Modified:
1 year, 6 months ago
Reviewers:
sergei, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6559 - Change SpecialSubscription.defaultsMap to Map object

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M lib/subscriptionClasses.js View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
1 year, 6 months ago (2018-06-08 14:45:05 UTC) #1
Manish Jethani
Patch Set 1
1 year, 6 months ago (2018-06-08 14:46:35 UTC) #2
kzar
LGTM. I guess you should add an integration note to the issue to mention that ...
1 year, 6 months ago (2018-06-12 14:17:37 UTC) #3
Manish Jethani
1 year, 6 months ago (2018-06-12 19:11:02 UTC) #4
On 2018/06/12 14:17:37, kzar wrote:
> LGTM.

Thanks!

> I guess you should add an integration note to the issue to mention that the
type
> of SpecialSubscription.defaultsMap 
>  is changing. That said I can't see it being used in adblockpluschrome or
> adblockplusui, so perhaps it doesn't matter in practice.

Makes sense, done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5