Issue 29802587: Issue 6559 - Change SpecialSubscription.defaultsMap to Map object

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29802587: Issue 6559 - Change SpecialSubscription.defaultsMap to Map object (Closed)

Created:
June 8, 2018, 2:45 p.m. by Manish Jethani

Modified:
June 12, 2018, 7:11 p.m.

Reviewers:
sergei, kzar

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Issue 6559 - Change SpecialSubscription.defaultsMap to Map object

Patch Set 1 #

Created: June 8, 2018, 2:45 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	lib/subscriptionClasses.js	View		4 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kzar

LGTM. I guess you should add an integration note to the issue to mention that ...

June 12, 2018, 2:17 p.m. (2018-06-12 14:17:37 UTC) #3

Manish Jethani

June 12, 2018, 7:11 p.m. (2018-06-12 19:11:02 UTC) #4

On 2018/06/12 14:17:37, kzar wrote:
> LGTM.

Thanks!

> I guess you should add an integration note to the issue to mention that the
type
> of SpecialSubscription.defaultsMap 
>  is changing. That said I can't see it being used in adblockpluschrome or
> adblockplusui, so perhaps it doesn't matter in practice.

Makes sense, done.

Expand All Messages | Collapse All Messages