Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29802599: Fixes #92 - Changed color of index page download button to green (Closed)

Created:
June 8, 2018, 5:02 p.m. by juliandoucette
Modified:
June 11, 2018, 12:30 p.m.
Reviewers:
ire
CC:
saroyanm
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #92 - Changed color of index page download button to green

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed #3 #

Patch Set 3 : Addressed #6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M includes/hero-download.html View 1 chunk +1 line, -1 line 0 comments Download
M static/css/index.css View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8
juliandoucette
June 8, 2018, 5:02 p.m. (2018-06-08 17:02:28 UTC) #1
juliandoucette
CC saroyanm (in-case ire doesn't have time).
June 8, 2018, 5:03 p.m. (2018-06-08 17:03:02 UTC) #2
ire
Thanks Julian! LGTM + Suggest https://codereview.adblockplus.org/29802599/diff/29802600/static/css/index.css File static/css/index.css (right): https://codereview.adblockplus.org/29802599/diff/29802600/static/css/index.css#newcode104 static/css/index.css:104: #hero-download-button:hover Suggest: Add this ...
June 8, 2018, 6:03 p.m. (2018-06-08 18:03:40 UTC) #3
juliandoucette
On 2018/06/08 18:03:40, ire wrote: > https://codereview.adblockplus.org/29802599/diff/29802600/static/css/index.css#newcode104 > static/css/index.css:104: #hero-download-button:hover > Suggest: Add this still ...
June 8, 2018, 6:17 p.m. (2018-06-08 18:17:59 UTC) #4
juliandoucette
Updated. Also https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/92#note_80146334 I'm assuming she miss-copy/pasted in my latest patchset. I think it makes ...
June 8, 2018, 6:23 p.m. (2018-06-08 18:23:13 UTC) #5
juliandoucette
Updated. Scrap that. I shouldn't assume she miss-copy/pasted. A light active state makes sense too.
June 8, 2018, 6:29 p.m. (2018-06-08 18:29:39 UTC) #6
ire
On 2018/06/08 18:29:39, juliandoucette wrote: > Updated. Scrap that. I shouldn't assume she miss-copy/pasted. A ...
June 8, 2018, 6:30 p.m. (2018-06-08 18:30:21 UTC) #7
juliandoucette
June 11, 2018, 12:30 p.m. (2018-06-11 12:30:04 UTC) #8
On 2018/06/08 18:30:21, ire wrote:
> Ack. LGTM

Done https://hg.adblockplus.org/web.adblockplus.org/rev/57d48bf08486.

Powered by Google App Engine
This is Rietveld