Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(439)

Issue 29803559: Issue 6741 - Use ES2015 classes in lib/filterClasses.js

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by Manish Jethani
Modified:
2 months, 3 weeks ago
Reviewers:
sergei
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -332 lines) Patch
M lib/filterClasses.js View 10 chunks +370 lines, -332 lines 3 comments Download

Messages

Total messages: 5
Manish Jethani
4 months, 1 week ago (2018-06-09 12:51:37 UTC) #1
Manish Jethani
Patch Set 1 What do you think? The general pattern is: /** * Description of ...
4 months, 1 week ago (2018-06-09 13:03:32 UTC) #2
kzar
I mean sure, the new class syntax looks OK to me I guess. I'm not ...
4 months, 1 week ago (2018-06-12 11:46:15 UTC) #3
Manish Jethani
On 2018/06/12 11:46:15, kzar wrote: > I mean sure, the new class syntax looks OK ...
4 months, 1 week ago (2018-06-12 11:59:15 UTC) #4
kzar
2 months, 3 weeks ago (2018-07-27 11:09:13 UTC) #5

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5