Unified Diff: lib/synchronizer.js
Issue 29804571:
Noissue - Remove unnecessary references to undefined (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set:
Created June 12, 2018, 4:27 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« lib/filterStorage.js ('K')
|
« lib/filterStorage.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/synchronizer.js |
| =================================================================== |
| --- a/lib/synchronizer.js |
| +++ b/lib/synchronizer.js |
| @@ -281,18 +281,16 @@ |
| for (let line of lines) |
| { |
| line = Filter.normalize(line); |
| if (line) |
| filters.push(Filter.fromText(line)); |
| } |
| FilterStorage.updateSubscriptionFilters(subscription, filters); |
| - |
| - return undefined; |
|
Manish Jethani
2018/06/12 04:33:25
Totally redundant, a function returns undefined by
|
| }, |
| _onDownloadError(downloadable, downloadURL, error, channelStatus, |
| responseStatus, redirectCallback) |
| { |
| let subscription = Subscription.fromURL(downloadable.url); |
| subscription.lastDownload = Math.round(Date.now() / MILLIS_IN_SECOND); |
| subscription.downloadStatus = error; |
« lib/filterStorage.js ('K')
|
« lib/filterStorage.js ('k')
|
no next file »
|
no next file with comments »
