Issue 6744 - Fixed wrapper injection on Chrome 67

Issue 6744 - Fixed wrapper injection on Chrome 67

[Sebastian Noack, 2018-06-14 21:03:10]

I'm planning to still land this in master. Causing Adblock Plus to show an error
in the console for many websites is quite bad alone, plus the WebRTC wrapper
won't work anymore. This is somewhat a regression, however, not in Adblock Plus,
but in the latest Chrome release.

https://codereview.adblockplus.org/29807586/diff/29807587/inject.preload.js
File inject.preload.js (right):

https://codereview.adblockplus.org/29807586/diff/29807587/inject.preload.js#n...
inject.preload.js:373: if
(browser.runtime.getURL("").startsWith("chrome-extension://"))
FWIW, I'm not too happy with this check, but I don't have a better idea.
Ideally, we'd just try to load the script from the blob: URL and then fall back
to textContent, but while this would fix the wrapper, there still would be a
failed request logged to the console.

[kzar, 2018-06-15 07:52:07]

LGTM

https://codereview.adblockplus.org/29807586/diff/29807587/inject.preload.js
File inject.preload.js (right):

https://codereview.adblockplus.org/29807586/diff/29807587/inject.preload.js#n...
inject.preload.js:373: if
(browser.runtime.getURL("").startsWith("chrome-extension://"))
On 2018/06/14 21:03:09, Sebastian Noack wrote:
> FWIW, I'm not too happy with this check, but I don't have a better idea.
> Ideally, we'd just try to load the script from the blob: URL and then fall
back
> to textContent, but while this would fix the wrapper, there still would be a
> failed request logged to the console.

Acknowledged.