Issue 29808563: Fixes #38 - Added alert to element hiding helper page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29808563: Fixes #38 - Added alert to element hiding helper page (Closed)

Created:
June 15, 2018, 10:55 a.m. by juliandoucette

Modified:
June 19, 2018, 10:53 a.m.

Reviewers:
ire

Base URL:
https://hg.adblockplus.org/web.adblockplus.org

Visibility:
Public.

Description

Fixes #38 - Added alert to element hiding helper page

Patch Set 1 #

Total comments: 1

Created: June 15, 2018, 10:55 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pages/elemhidehelper.html	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ire

LGTM + NIT https://codereview.adblockplus.org/29808563/diff/29808564/pages/elemhidehelper.html File pages/elemhidehelper.html (right): https://codereview.adblockplus.org/29808563/diff/29808564/pages/elemhidehelper.html#newcode3 pages/elemhidehelper.html:3: <p class="alert">{{depricated-alert[notification] Deprecated since ABP 3.0. ...

June 18, 2018, 11:31 p.m. (2018-06-18 23:31:19 UTC) #2

juliandoucette

June 19, 2018, 10:47 a.m. (2018-06-19 10:47:09 UTC) #3

On 2018/06/18 23:31:19, ire wrote:
> LGTM + NIT
> 
>
https://codereview.adblockplus.org/29808563/diff/29808564/pages/elemhidehelpe...
> File pages/elemhidehelper.html (right):
> 
>
https://codereview.adblockplus.org/29808563/diff/29808564/pages/elemhidehelpe...
> pages/elemhidehelper.html:3: <p class="alert">{{depricated-alert[notification]
> Deprecated since ABP 3.0. Although it might still work with some extensions,
it
> could become obsolete at any time. }}</p>
> NIT: Misspell "depricated"

Good catch!

Expand All Messages | Collapse All Messages