Noissue - Use destructuring

lib/ioIndexedDB.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 91 matching lines @@
     transaction.oncomplete = event =>
     {
       resolve(filesData);
     };
 
     cursorReq.onsuccess = event =>
     {
       let cursor = event.currentTarget.result;
       if (cursor)
       {
-        let value = cursor.value;
+        let {value} = cursor;

[Sebastian Noack, 2018/06/15 20:13:57]

Shouldn't this one at least trigger an eslint error?

[hub, 2018/06/15 20:20:03]

both were triggered. that's why I'm fixing them.

[Sebastian Noack, 2018/06/15 21:18:33]

Weird, not for me:

$ hg id
d97edcab2c18 tip next
$ hg st
$ eslint *.js lib/ qunit/ ext/ chrome
$

 
         filesData.push({
           fileName: cursor.key,
           content: value.content,
           lastModified: value.lastModified
         });
         cursor.continue();
       }
     };
 
@@ skipping 36 matching lines @@
 
 function getFile(fileName, dbInstance, storeName)
 {
   return new Promise((resolve, reject) =>
   {
     let store = getObjectStore(dbInstance, storeName);
     let req = store.get(fileToKey(fileName));
 
     req.onsuccess = event =>
     {
-      let result = event.currentTarget.result;
+      let {result} = event.currentTarget;
 
       if (result)
         resolve(result);
       else
         reject({type: "NoSuchFile"});
     };
     req.onerror = reject;
   });
 }
 
@@ skipping 114 matching lines @@
                 fileName: fileToKey(newName),
                 content: fileData.content,
                 lastModified: fileData.lastModified
               },
               dbInstance,
               dbConfig.storeName))
           .then(() => deleteFile(fromFile, dbInstance, dbConfig.storeName))));
   }
 };